III-6239 tariff name trimmed #1736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonasVHG
requested review from
LucWollants,
simon-debruijn and
grubolsch
as code owners
LucWollants
reviewed
Aug 5, 2024
LucWollants
reviewed
Aug 5, 2024
src/Http/Offer/PriceInfoDuplicateNameValidatingRequestBodyParser.php
Outdated
Show resolved
Hide resolved
simon-debruijn
requested changes
Aug 5, 2024
src/Http/Offer/PriceInfoDuplicateNameValidatingRequestBodyParser.php
Outdated
Show resolved
Hide resolved
tests/Http/Offer/PriceInfoDuplicateNameValidatingRequestBodyParserTest.php
Outdated
Show resolved
Hide resolved
Co-authored-by: Luc Wollants <[email protected]>
…er.php Co-authored-by: Simon de Bruijn <[email protected]>
LucWollants
reviewed
Aug 6, 2024
src/Http/Offer/PriceInfoDuplicateNameValidatingRequestBodyParser.php
Outdated
Show resolved
Hide resolved
LucWollants
approved these changes
Aug 6, 2024
simon-debruijn
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed
PriceInfoDuplicateNameValidatingRequestBodyParser: Improved check on duplicateTariffName, to take spacing into account.PriceInfoDuplicateNameValidatingRequestBodyParserTest: refactor to avoid endless casting toobjectvia new private function
arrayAsObject()+ new test for trimmingTicket: https://jira.publiq.be/browse/III-6239