Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

III-4896 Add PSR router #1102

Merged
merged 40 commits into from
Aug 23, 2022
Merged

III-4896 Add PSR router #1102

merged 40 commits into from
Aug 23, 2022

Commits on Aug 22, 2022

  1. Add league/route package

    @bertramakers
    bertramakers committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    392e5b1 View commit details
    Browse the repository at this point in the history

  2. Rename LegacyRoutesServiceProvider to CatchAllRouteServiceProvider

    @bertramakers
    bertramakers committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    bfa5ef4 View commit details
    Browse the repository at this point in the history

  3. Store the original request

    @bertramakers
    bertramakers committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    8240ebe View commit details
    Browse the repository at this point in the history

  4. Register the league router

    @bertramakers
    bertramakers committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    96767d8 View commit details
    Browse the repository at this point in the history

  5. Dispatch unmatched requests to PSR router

    @bertramakers
    bertramakers committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    68afe45 View commit details
    Browse the repository at this point in the history

  6. Also catch MethodNotAllowedException

    @bertramakers
    bertramakers committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    6e67940 View commit details
    Browse the repository at this point in the history

  7. Let the PSR router handle the original request

    @bertramakers
    bertramakers committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    e9e2f28 View commit details
    Browse the repository at this point in the history

  8. Move rewrite logic to function

    @bertramakers
    bertramakers committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    1bd51d0 View commit details
    Browse the repository at this point in the history

  9. Rename $pathHasBeenRewritten to $pathHasBeenRewrittenBefore

    @bertramakers
    bertramakers committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    465157f View commit details
    Browse the repository at this point in the history

  10. Make the event/place pluralisation work if there is a slash prefixed

    @bertramakers
    bertramakers committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    ac0da1d View commit details
    Browse the repository at this point in the history

  11. Always immediately rewrite the path before sending the request to the… 

    … PSR router
    @bertramakers
    bertramakers committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    3f2b1ef View commit details
    Browse the repository at this point in the history

  12. Only add a trailing slash in case of a rewrite for the Silex router

    @bertramakers
    bertramakers committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    8dfa62c View commit details
    Browse the repository at this point in the history

  13. Update comment

    @bertramakers
    bertramakers committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    d77442d View commit details
    Browse the repository at this point in the history

  14. Move Silex sub-request dispatching higher up for readability

    @bertramakers
    bertramakers committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    6e35ee3 View commit details
    Browse the repository at this point in the history

  15. Move PSR router dispatching out of else

    @bertramakers
    bertramakers committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    97c0a62 View commit details
    Browse the repository at this point in the history

  16. Explain flow

    @bertramakers
    bertramakers committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    a6e6aa3 View commit details
    Browse the repository at this point in the history

  17. Rename $pathHasBeenRewrittenBefore for clarity

    @bertramakers
    bertramakers committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    5e981b6 View commit details
    Browse the repository at this point in the history

  18. (Better) Explain why we rewrite the path before dispatching it on the… 

    … PSR router
    @bertramakers
    bertramakers committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    8308986 View commit details
    Browse the repository at this point in the history

  19. Move route to get event/place JSON to new router as proof-of-concept

    @bertramakers
    bertramakers committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    5c0c2ff View commit details
    Browse the repository at this point in the history

  20. Fix for route parameters that are not found in new router

    @bertramakers
    bertramakers committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    52a1210 View commit details
    Browse the repository at this point in the history

  21. Merge branch 'master' into III-4896-psr-router

    @bertramakers
    bertramakers committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    4ddcbab View commit details
    Browse the repository at this point in the history

  22. Update RouteParameters tests to reflect new logic

    @bertramakers
    bertramakers committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    3b792e7 View commit details
    Browse the repository at this point in the history

  23. Follow approach of the new PSR router in Psr7RequestBuilder for tests

    @bertramakers
    bertramakers committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    d9f558d View commit details
    Browse the repository at this point in the history

  24. Match OPTIONS requests in new router

    @bertramakers
    bertramakers committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    f6c9e57 View commit details
    Browse the repository at this point in the history

  25. Add comment to move CORS headers middleware to PSR-15 middleware later 

    It still works for all routes, also those matched by the new router. And if we move it now it won't work anymore for routes matched by the Silex router. So we need to move all the routes to the new router first
    @bertramakers
    bertramakers committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    323973a View commit details
    Browse the repository at this point in the history

  26. Merge branch 'master' into III-4896-psr-router

    @bertramakers
    bertramakers committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    602c20e View commit details
    Browse the repository at this point in the history

  27. Move inline $rewrite function to class

    @bertramakers
    bertramakers committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    7de8cef View commit details
    Browse the repository at this point in the history

  28. Add tests for LegacyPathRewriter

    @bertramakers
    bertramakers committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    309cfd9 View commit details
    Browse the repository at this point in the history

  29. Move PSR-router logic into an ApplicationRequestHandler

    @bertramakers
    bertramakers committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    ffa6ed2 View commit details
    Browse the repository at this point in the history

  30. Rename rewrite() to rewritePath()

    @bertramakers
    bertramakers committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    0a0e33c View commit details
    Browse the repository at this point in the history

  31. Move request rewrite logic to LegacyPathRewriter

    @bertramakers
    bertramakers committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    b372a9d View commit details
    Browse the repository at this point in the history

  32. Move error handling from ApplicationRequestHandler to WebErrorHandler… 

    …Provider

Better to stay consistent, and we will refactor the error handling in a later ticket
    @bertramakers
    bertramakers committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    b66e3d1 View commit details
    Browse the repository at this point in the history

  33. Remove ApplicationRequestHandler again now that is basically does not… 

    …hing
    @bertramakers
    bertramakers committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    4e86b14 View commit details
    Browse the repository at this point in the history

  34. Linting™

    @bertramakers
    bertramakers committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    ac33cdf View commit details
    Browse the repository at this point in the history

  35. Add comment about PSR router

    @bertramakers
    bertramakers committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    2f616ee View commit details
    Browse the repository at this point in the history

  36. New router does not ignore trailing slashes after all

    @bertramakers
    bertramakers committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    885bf4b View commit details
    Browse the repository at this point in the history

  37. Use a custom strategy to handle OPTIONS requests

    @bertramakers
    bertramakers committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    02a0feb View commit details
    Browse the repository at this point in the history

  38. Add catch-all route in Silex router again for OPTIONS requests 

    Otherwise routes that are not registered in the new router yet will not work with CORS anymore
    @bertramakers
    bertramakers committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    b5f02e8 View commit details
    Browse the repository at this point in the history

  39. Linting™ in code copied from ApplicationStrategy

    @bertramakers
    bertramakers committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    21a4c9f View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2022

  1. Do not match with a URL like /foo/bar

    @bertramakers
    bertramakers committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    4d1d2fe View commit details
    Browse the repository at this point in the history