Merge pull request #1739 from cultuurnet/III-6150-avoid-alias-functions

III-6150 Avoid alias functions
cultuurnet · Aug 7, 2024 · ce61f48 · ce61f48
2 parents 1c87a1a + c93ddfb
commit ce61f48
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 11 deletions.
diff --git a/app/Console/Command/ReplayCommand.php b/app/Console/Command/ReplayCommand.php
@@ -141,7 +141,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
         // since we cannot catch errors when multiple cdbids are giving
         // and this Command is mostly run via Jenkins with exactly 1 cdbid
         // we will only fix this for the first cdbid
-        if ($cdbids !== null && sizeof($cdbids) === 1) {
+        if ($cdbids !== null && count($cdbids) === 1) {
             $this->purgeReadmodels($cdbids[0]);
         }
 

diff --git a/composer.lock b/composer.lock
diff --git a/features/Steps/RoleSteps.php b/features/Steps/RoleSteps.php
@@ -54,7 +54,7 @@ public function rolesTestDataIsAvailable(): void
     {
         // Create role "Diest Validatoren"
         $this->iSearchForARoleWithName('Diest validatoren');
-        if (sizeof($this->responseState->getJsonContent()['member']) === 0) {
+        if (count($this->responseState->getJsonContent()['member']) === 0) {
             $this->createRole('Diest validatoren');
             $uuidRoleDiest = $this->responseState->getJsonContent()['roleId'];
             $this->iSetTheJsonRequestPayloadTo(new PyStringNode(['{ "query": "(regions:nis-24020 OR labels:UiTinMijnRegio)" }'], 0));
@@ -76,7 +76,7 @@ public function rolesTestDataIsAvailable(): void
 
         // Create role "Scherpenheuvel Validatoren"
         $this->iSearchForARoleWithName('Scherpenheuvel validatoren');
-        if (sizeof($this->responseState->getJsonContent()['member']) === 0) {
+        if (count($this->responseState->getJsonContent()['member']) === 0) {
             $this->createRole('Scherpenheuvel validatoren');
             $uuidRoleScherpenheuvel = $this->responseState->getJsonContent()['roleId'];
             $this->iSetTheJsonRequestPayloadTo(new PyStringNode(['{"query": "regions:nis-24134"}'], 0));
@@ -91,7 +91,7 @@ public function rolesTestDataIsAvailable(): void
 
         // Create role "Vlaams-Brabant validatoren"
         $this->iSearchForARoleWithName('Provincie Vlaams-Brabant validatoren');
-        if (sizeof($this->responseState->getJsonContent()['member']) === 0) {
+        if (count($this->responseState->getJsonContent()['member']) === 0) {
             $this->createRole('Provincie Vlaams-Brabant validatoren');
             $uuidRolePvb = $this->responseState->getJsonContent()['roleId'];
             $this->iSetTheJsonRequestPayloadTo(new PyStringNode(['{ "query": "regions:nis-20001" }'], 0));

diff --git a/src/Geocoding/Coordinate/Coordinate.php b/src/Geocoding/Coordinate/Coordinate.php
@@ -10,7 +10,7 @@ abstract class Coordinate
 
     public function __construct(float $value)
     {
-        if (!is_double($value)) {
+        if (!is_float($value)) {
             throw new \InvalidArgumentException('Coordinate value should be of type double.');
         }