fix: issues with ecs-task-runner during prototyping #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
therealvio
force-pushed
the
working-the-prototype
branch
from
c71c2f0 to
7bcab5b
Compare
Prior to this change, the parameter name was in camelCase, and this casing appears to transfer over when Buildkite sets up the environment variables for the plugin. This change uses kebab case for the parameter, which is the casing Buildkite expects. In turn, this transforms in UPPER_SNAKE_CASE when the environment variables are set up.
This change fixes a missing pointer dereference so that the exit code of the task is correctly compared, and the correct message is returned based on the comparison.
therealvio
force-pushed
the
working-the-prototype
branch
from
7bcab5b to
1ce353d
Compare
Although the primary use of the task runner is for database migrations, there isn't anything specific to the code that indicates it is only capable of doing this. Hence, we will keep the name of the tasks and container generic, and leave the application up to the people who consume the plugin.
therealvio
force-pushed
the
working-the-prototype
branch
from
88a11cc to
83441e1
Compare
liamstevens
approved these changes
Dec 19, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose 🎯
These changes feature various fixes that were identified during prototyping of the Buildkite plugin for the
permissions-service. These fixes will ensure that the plugin will be suitable for future projects to use.Overall the changes are as follows:
Context 🧠