Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build test jar with config-impl support classes #54

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

svenhaag
Copy link
Collaborator

@svenhaag svenhaag commented Aug 2, 2024

No description provided.

Copy link

sonarcloud bot commented Aug 2, 2024

Copy link
Owner

@cuioss cuioss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi. Ich bin mir nicht ganz sicher ob das notwendig ist: Die Klassen hier sollten eigentlich in portal-ui-unit-testing enthalten sein. Ich habe die ein oder andere Klasse extra dupliziert

@svenhaag
Copy link
Collaborator Author

Ich vermisse nur den PortalConfigurationMock.

@cuioss
Copy link
Owner

cuioss commented Aug 21, 2024

Wie ich im Slack sehe, hast du PortalTestConfiguration inzwischen gefunden

@cuioss
Copy link
Owner

cuioss commented Sep 5, 2024

Können wir den schliessen?

@svenhaag
Copy link
Collaborator Author

svenhaag commented Sep 5, 2024

Hi, ja, man müsste nur noch den de.cuioss.portal.configuration.impl.support.PortalConfigurationMock rüberkopieren oder man merged ihn. Ggf kann man dan die anderen Mock Duplikate sogar entfernen?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants