Skip to content

Commit

Permalink
Refactored literal
Browse files Browse the repository at this point in the history
  • Loading branch information
cuioss committed Jul 20, 2023
1 parent 2b40776 commit 4c57ff3
Show file tree
Hide file tree
Showing 6 changed files with 22 additions and 22 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,14 @@
import javax.servlet.ServletRequest;
import javax.servlet.ServletResponse;

import de.cuioss.portal.core.cdi.servlet.literal.DestroyedLiteral;
import de.cuioss.portal.core.cdi.servlet.literal.Initialized;
import de.cuioss.portal.core.cdi.servlet.literal.InitializedLiteral;
import de.cuioss.portal.core.cdi.servlet.literal.ServletDestroyedLiteral;
import de.cuioss.portal.core.cdi.servlet.literal.ServletInitialized;
import de.cuioss.portal.core.cdi.servlet.literal.ServletInitializedLiteral;
import de.cuioss.tools.logging.CuiLogger;

/**
* Inspired by deltaspike. Fires events for {@link Initialized} and
* {@link Destroyed}.
* Inspired by deltaspike. Fires events for {@link ServletInitialized} and
* {@link ServletDestroyed}.
*/
public class RequestResponseEventFilter implements Filter {

Expand All @@ -29,16 +29,16 @@ public void doFilter(ServletRequest request, ServletResponse response, FilterCha
var beanManager = CDI.current().getBeanManager();

LOGGER.trace("Fire @Initialized events");
beanManager.fireEvent(request, InitializedLiteral.INSTANCE);
beanManager.fireEvent(response, InitializedLiteral.INSTANCE);
beanManager.fireEvent(request, ServletInitializedLiteral.INSTANCE);
beanManager.fireEvent(response, ServletInitializedLiteral.INSTANCE);

try {
LOGGER.trace("Execute Chain");
chain.doFilter(request, response);
} finally {
LOGGER.trace("Fire @Destroyed events");
beanManager.fireEvent(request, DestroyedLiteral.INSTANCE);
beanManager.fireEvent(response, DestroyedLiteral.INSTANCE);
beanManager.fireEvent(request, ServletDestroyedLiteral.INSTANCE);
beanManager.fireEvent(response, ServletDestroyedLiteral.INSTANCE);
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,6 @@
@Target({ TYPE, METHOD, PARAMETER, FIELD })
@Retention(RUNTIME)
@Documented
public @interface Destroyed {
public @interface ServletDestroyed {

}
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,13 @@
import javax.enterprise.util.AnnotationLiteral;

/**
* Annotation literal for {@link DestroyedLiteral}.
* Annotation literal for {@link ServletDestroyedLiteral}.
*
* @author https://github.com/apache/deltaspike/blob/deltaspike-1.9.6/deltaspike/core/api/src/main/java/org/apache/deltaspike/core/api/literal/DestroyedLiteral.java
*/
public class DestroyedLiteral extends AnnotationLiteral<Initialized> implements Destroyed {
public class ServletDestroyedLiteral extends AnnotationLiteral<ServletInitialized> implements ServletDestroyed {

private static final long serialVersionUID = 5587631398288144209L;
public static final Destroyed INSTANCE = new DestroyedLiteral();
public static final ServletDestroyed INSTANCE = new ServletDestroyedLiteral();

}
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,6 @@
@Target({ TYPE, METHOD, PARAMETER, FIELD })
@Retention(RUNTIME)
@Documented
public @interface Initialized {
public @interface ServletInitialized {

}
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,14 @@
import javax.enterprise.util.AnnotationLiteral;

/**
* Annotation literal for {@link Initialized}.
* Annotation literal for {@link ServletInitialized}.
*
* @author https://github.com/apache/deltaspike/blob/deltaspike-1.9.6/deltaspike/core/api/src/main/java/org/apache/deltaspike/core/api/literal/InitializedLiteral.java
*/
public class InitializedLiteral extends AnnotationLiteral<Initialized> implements Initialized {
public class ServletInitializedLiteral extends AnnotationLiteral<ServletInitialized> implements ServletInitialized {

private static final long serialVersionUID = 1268993406072023790L;

public static final Initialized INSTANCE = new InitializedLiteral();
public static final ServletInitialized INSTANCE = new ServletInitializedLiteral();

}
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;

import de.cuioss.portal.core.cdi.servlet.literal.Initialized;
import de.cuioss.portal.core.cdi.servlet.literal.ServletInitialized;

@EnableAutoWeld
class RequestResponseEventFilterTest {
Expand Down Expand Up @@ -48,19 +48,19 @@ void shouldFilter() throws IOException, ServletException {
assertTrue(initResponse);
}

void initRequest(@Observes @Initialized HttpServletRequest request) {
void initRequest(@Observes @ServletInitialized HttpServletRequest request) {
initRequest = true;
}

void destroyRequest(@Observes @Initialized HttpServletRequest request) {
void destroyRequest(@Observes @ServletInitialized HttpServletRequest request) {
destroyRequest = true;
}

void initResponse(@Observes @Initialized HttpServletResponse request) {
void initResponse(@Observes @ServletInitialized HttpServletResponse request) {
initResponse = true;
}

void destroyResponse(@Observes @Initialized HttpServletResponse request) {
void destroyResponse(@Observes @ServletInitialized HttpServletResponse request) {
destroyResponse = true;
}

Expand Down

0 comments on commit 4c57ff3

Please sign in to comment.