Removing surplus supressionsp

modules/authentication/portal-authentication-api/src/test/java/de/cuioss/portal/authentication/model/ContextMapGenerator.java

@@ -22,7 +22,7 @@
 import de.cuioss.test.generator.Generators;
 import de.cuioss.test.generator.TypedGenerator;
 
-@SuppressWarnings({ "rawtypes", "javadoc" })
+@SuppressWarnings({ "rawtypes" })
 public class ContextMapGenerator implements TypedGenerator<Map> {
 
     private final TypedGenerator<String> stringGenerator = Generators.nonEmptyStrings();

modules/authentication/portal-authentication-mock/src/main/java/de/cuioss/portal/authentication/mock/MockAuthenticationFacade.java

@@ -19,7 +19,6 @@
 
 import java.util.ArrayList;
 import java.util.List;
-import java.util.stream.Collectors;
 
 import javax.enterprise.context.ApplicationScoped;
 import javax.inject.Inject;

modules/authentication/portal-authentication-oauth/src/test/java/de/cuioss/portal/authentication/oauth/impl/OIDCWellKnownDispatcher.java

@@ -39,7 +39,6 @@
 import mockwebserver3.MockWebServer;
 import mockwebserver3.RecordedRequest;
 
-@SuppressWarnings("javadoc")
 public class OIDCWellKnownDispatcher extends Dispatcher {
 
     private static final Logger LOGGER = LoggerFactory.getLogger(OIDCWellKnownDispatcher.class);

modules/authentication/portal-authentication-oauth/src/test/java/de/cuioss/portal/authentication/oauth/impl/Oauth2ServiceMock.java

@@ -27,7 +27,6 @@
 import lombok.Getter;
 import lombok.Setter;
 
-@SuppressWarnings("javadoc")
 public class Oauth2ServiceMock implements Oauth2Service, Serializable {
 
     private static final long serialVersionUID = -2635417375165112609L;

modules/authentication/portal-authentication-oauth/src/test/java/de/cuioss/portal/authentication/oauth/impl/RedirectorMock.java

@@ -20,7 +20,6 @@
 import de.cuioss.portal.authentication.oauth.OauthRedirector;
 import lombok.Getter;
 
-@SuppressWarnings("javadoc")
 @ApplicationScoped
 public class RedirectorMock implements OauthRedirector {
 

modules/configuration/portal-configuration-api/src/main/java/de/cuioss/portal/configuration/util/ConfigPlaceholder.java

@@ -30,7 +30,7 @@
 @ToString
 @EqualsAndHashCode
 class ConfigPlaceholder {
-
+    @SuppressWarnings("el-syntax")
     private static final String PLACEHOLDER_PREFIX = "${";
     private static final String PLACEHOLDER_SUFFIX = "}";
     private static final String PLACEHOLDER_DEFAULT_VALUE_SPLITTER = ":";

modules/configuration/portal-configuration-api/src/test/java/de/cuioss/portal/configuration/connections/impl/generator/ContextMapGenerator.java

@@ -24,7 +24,7 @@
 
 import de.cuioss.test.generator.TypedGenerator;
 
-@SuppressWarnings({ "rawtypes", "javadoc" })
+@SuppressWarnings({ "rawtypes" })
 public class ContextMapGenerator implements TypedGenerator<Map> {
 
     private final TypedGenerator<String> stringGenerator = nonEmptyStrings();

modules/configuration/portal-configuration-api/src/test/java/de/cuioss/portal/configuration/connections/impl/generator/KeyStoreInfoGenerator.java

@@ -25,7 +25,6 @@
 import de.cuioss.tools.net.ssl.KeyStoreProvider;
 import de.cuioss.tools.net.ssl.KeyStoreType;
 
-@SuppressWarnings("javadoc")
 public class KeyStoreInfoGenerator implements TypedGenerator<KeyStoreProvider> {
 
     static final String PASSWORD = "initinit";

modules/configuration/portal-configuration-api/src/test/java/de/cuioss/portal/configuration/connections/impl/generator/TrustStoreInfoGenerator.java

@@ -25,7 +25,6 @@
 import de.cuioss.tools.net.ssl.KeyStoreProvider;
 import de.cuioss.tools.net.ssl.KeyStoreType;
 
-@SuppressWarnings("javadoc")
 public class TrustStoreInfoGenerator implements TypedGenerator<KeyStoreProvider> {
 
     private final TypedGenerator<File> trustores = fixedValues(BASE_PATH.resolve("truststore1.keystore").toFile(),

modules/configuration/portal-configuration-api/src/test/java/de/cuioss/portal/configuration/impl/support/EmptyFilterConfiguration.java

@@ -26,7 +26,6 @@
 import lombok.Getter;
 import lombok.Setter;
 
-@SuppressWarnings("javadoc")
 @ApplicationScoped
 public class EmptyFilterConfiguration {
 

modules/configuration/portal-configuration-api/src/test/java/de/cuioss/portal/configuration/impl/support/ExplodingFileLoader.java

@@ -22,7 +22,6 @@
 import de.cuioss.tools.io.FileLoader;
 import de.cuioss.tools.io.StructuredFilename;
 
-@SuppressWarnings("javadoc")
 public class ExplodingFileLoader implements FileLoader {
 
     private static final long serialVersionUID = -2232945095983152163L;

modules/configuration/portal-configuration-api/src/test/java/de/cuioss/portal/configuration/impl/support/HappyCaseFilterConfiguration.java

@@ -28,7 +28,6 @@
 import lombok.Getter;
 import lombok.Setter;
 
-@SuppressWarnings("javadoc")
 @ApplicationScoped
 public class HappyCaseFilterConfiguration {
 

modules/configuration/portal-configuration-api/src/test/java/de/cuioss/portal/configuration/impl/support/HappyCaseSingleConfiguration.java

@@ -28,7 +28,6 @@
 import lombok.Getter;
 import lombok.Setter;
 
-@SuppressWarnings("javadoc")
 @ApplicationScoped
 public class HappyCaseSingleConfiguration {
 

modules/configuration/portal-configuration-api/src/test/java/de/cuioss/portal/configuration/impl/support/InvalidFilterConfiguration.java

@@ -26,7 +26,6 @@
 import lombok.Getter;
 import lombok.Setter;
 
-@SuppressWarnings("javadoc")
 @ApplicationScoped
 public class InvalidFilterConfiguration {
 

modules/configuration/portal-configuration-api/src/test/java/de/cuioss/portal/configuration/util/ConfigPlaceholderTest.java

@@ -25,6 +25,7 @@
 import org.junit.jupiter.params.ParameterizedTest;
 import org.junit.jupiter.params.provider.CsvSource;
 
+@SuppressWarnings("el-syntax")
 class ConfigPlaceholderTest {
 
     @Test
@@ -55,6 +56,7 @@ void returnsDefaultValueIfNotNull() {
         assertEquals("default", nullDefault.get());
     }
 
+
     @Test
     void verifyInvalidPlaceholders() {
         assertFalse(ConfigPlaceholder.isPlaceholder(null));

modules/configuration/portal-configuration-api/src/test/java/de/cuioss/portal/configuration/util/ConfigurationHelperTest.java

@@ -213,6 +213,7 @@ void resolveAnnotationOrThrow() {
     }
 
     @Test
+    @SuppressWarnings("el-syntax")
     void ignoresOtherUnresolvableKeys() {
         setProperty("a.config.key", "value");
         setProperty("unresolvable.key", "${not.there}");

modules/configuration/portal-configuration-api/src/test/java/de/cuioss/portal/configuration/util/ConfigurationPlaceholderHelperTest.java

@@ -36,6 +36,7 @@
 
 @EnableTestLogger(debug = ConfigurationPlaceholderHelper.class)
 @TestInstance(TestInstance.Lifecycle.PER_METHOD)
+@SuppressWarnings("el-syntax")
 class ConfigurationPlaceholderHelperTest {
 
     private Set<String> addedSysProperties = new HashSet<>();

modules/configuration/portal-configuration-impl/src/main/java/de/cuioss/portal/configuration/impl/schedule/ConfigChangeObserver.java

@@ -227,7 +227,8 @@ private Map<String, String> getFileChangeDeltaMap(Path changedFilePath) {
         }
         return Collections.emptyMap();
     }
-
+
+    @SuppressWarnings("el-syntax")
     private boolean containsPlaceholder(final String haystack, final String needle) {
         return (null != haystack) && (null != needle)
                 && (haystack.contains("${" + needle + "}") || haystack.contains("${" + needle + ":"));

modules/configuration/portal-configuration-impl/src/test/java/de/cuioss/portal/configuration/impl/bundles/DefectBundle.java

@@ -31,7 +31,6 @@
 @Priority(PortalPriorities.PORTAL_ASSEMBLY_LEVEL)
 @EqualsAndHashCode
 @ToString
-@SuppressWarnings("javadoc")
 public class DefectBundle implements ResourceBundleLocator {
 
     private static final long serialVersionUID = 7756501560722570148L;

modules/configuration/portal-configuration-impl/src/test/java/de/cuioss/portal/configuration/impl/bundles/HighPrioBundles.java

@@ -31,7 +31,6 @@
 @Priority(PortalPriorities.PORTAL_ASSEMBLY_LEVEL)
 @EqualsAndHashCode
 @ToString
-@SuppressWarnings("javadoc")
 public class HighPrioBundles implements ResourceBundleLocator {
 
     private static final long serialVersionUID = 7756501560722570148L;

modules/configuration/portal-configuration-impl/src/test/java/de/cuioss/portal/configuration/impl/bundles/MediumPrioBundles.java

@@ -31,7 +31,6 @@
 @Priority(PortalPriorities.PORTAL_MODULE_LEVEL)
 @EqualsAndHashCode
 @ToString
-@SuppressWarnings("javadoc")
 public class MediumPrioBundles implements ResourceBundleLocator {
 
     private static final long serialVersionUID = 7756501560722570148L;

modules/configuration/portal-configuration-impl/src/test/java/de/cuioss/portal/configuration/impl/schedule/ConfigChangeObserverTest.java

@@ -47,6 +47,7 @@
 
 @EnableAutoWeld
 @AddBeanClasses({ PortalConfigProducer.class })
+@SuppressWarnings("el-syntax")
 class ConfigChangeObserverTest implements ShouldBeNotNull<ConfigChangeObserver> {
 
     private static final String CHILD_KEY = "child.key";

modules/configuration/portal-configuration-impl/src/test/java/de/cuioss/portal/configuration/impl/schedule/TestFileHandler.java

@@ -28,7 +28,6 @@
 import de.cuioss.tools.logging.CuiLogger;
 import lombok.Getter;
 
-@SuppressWarnings("javadoc")
 public final class TestFileHandler {
 
     private static final CuiLogger LOGGER = new CuiLogger(TestFileHandler.class);
@@ -110,7 +109,6 @@ public Path setupTestFileDirectory() throws IOException {
         return dir;
     }
 
-    @SuppressWarnings("resource")
     private Path setupTestFile(Path newFile) throws IOException {
         if (!newFile.toFile().exists()) {
             LOGGER.info("creating: {}", newFile.toAbsolutePath());

modules/configuration/portal-configuration-impl/src/test/java/de/cuioss/portal/configuration/impl/support/PortalConfigurationMock.java

@@ -120,7 +120,6 @@
 @ToString
 public class PortalConfigurationMock implements ConfigurationStorage, ConfigSource {
 
-    @SuppressWarnings("javadoc")
     public static final int PRIORITY = PortalPriorities.PORTAL_ASSEMBLY_LEVEL + 10;
 
     /**

modules/configuration/portal-configuration-impl/src/test/java/de/cuioss/portal/configuration/impl/support/TestPropertiesFileConfigurationSource.java

@@ -23,7 +23,6 @@
  */
 final public class TestPropertiesFileConfigurationSource extends PropertiesConfigSource {
 
-    @SuppressWarnings("javadoc")
     public TestPropertiesFileConfigurationSource() {
         super("target/test-classes/config/module.properties");
     }

modules/configuration/portal-configuration-impl/src/test/java/de/cuioss/portal/configuration/impl/support/TestYamlFileConfigurationSource.java

@@ -18,7 +18,6 @@
 import de.cuioss.portal.configuration.common.PortalPriorities;
 import de.cuioss.portal.configuration.yaml.YamlConfigSource;
 
-@SuppressWarnings("javadoc")
 public class TestYamlFileConfigurationSource extends YamlConfigSource {
 
     public TestYamlFileConfigurationSource() {

modules/configuration/portal-configuration-impl/src/test/java/de/cuioss/portal/configuration/impl/support/UnsupportedConfigSource.java

@@ -29,7 +29,6 @@
  */
 final public class UnsupportedConfigSource extends PropertiesConfigSource {
 
-    @SuppressWarnings("javadoc")
     public UnsupportedConfigSource() {
         super("file:target/test-classes/config/supported.not");
     }

modules/configuration/portal-configuration-standalone/src/test/java/de/cuioss/portal/configuration/standalone/source/InstallationConfigSourcePathInitializer.java

@@ -26,7 +26,6 @@
 import org.eclipse.microprofile.config.spi.ConfigSource;
 
 import de.cuioss.portal.configuration.ConfigurationSourceChangeEvent;
-import de.cuioss.portal.configuration.standalone.source.AbstractInstallationConfigSource;
 import de.cuioss.tools.logging.CuiLogger;
 
 /**

modules/configuration/portal-configuration-standalone/src/test/java/de/cuioss/portal/configuration/standalone/source/InstallationFileConfigSourceTest.java

@@ -30,7 +30,6 @@
 import org.junit.jupiter.api.AfterEach;
 import org.junit.jupiter.api.Test;
 
-import de.cuioss.portal.configuration.standalone.source.InstallationFileConfigSource;
 import de.cuioss.test.juli.TestLogLevel;
 import de.cuioss.test.juli.junit5.EnableTestLogger;
 import de.cuioss.tools.string.Joiner;

modules/configuration/portal-configuration-standalone/src/test/java/de/cuioss/portal/configuration/standalone/source/PortalConfigurationMock.java

@@ -120,7 +120,6 @@
 @ToString
 public class PortalConfigurationMock implements ConfigurationStorage, ConfigSource {
 
-    @SuppressWarnings("javadoc")
     public static final int PRIORITY = PortalPriorities.PORTAL_ASSEMBLY_LEVEL + 10;
 
     /**

modules/configuration/portal-configuration-standalone/src/test/java/de/cuioss/portal/configuration/standalone/source/PortalInstallationConfigurationTest.java

@@ -45,9 +45,6 @@
 import de.cuioss.portal.configuration.impl.schedule.ConfigChangeObserver;
 import de.cuioss.portal.configuration.impl.schedule.FileWatcherServiceImpl;
 import de.cuioss.portal.configuration.schedule.FileChangedEvent;
-import de.cuioss.portal.configuration.standalone.source.AbstractInstallationConfigSource;
-import de.cuioss.portal.configuration.standalone.source.InstallationFileConfigSource;
-import de.cuioss.portal.configuration.standalone.source.InstallationProductionFileConfigSource;
 import de.cuioss.test.generator.Generators;
 import de.cuioss.test.generator.TypedGenerator;
 import de.cuioss.test.juli.junit5.EnableTestLogger;

modules/configuration/portal-configuration-yaml/src/main/java/de/cuioss/portal/configuration/yaml/YamlDefaultConfigSource.java

@@ -35,7 +35,6 @@
  */
 public final class YamlDefaultConfigSource extends YamlConfigSource {
 
-    @SuppressWarnings("javadoc")
     public YamlDefaultConfigSource() {
         super(FileTypePrefix.CLASSPATH.getPrefix() + "/" + YamlDefaultConfigSourceProvider.META_INF_LOCATION);
     }

modules/core/portal-core/src/test/java/de/cuioss/portal/core/cdi/support/TestInterface.java

@@ -15,7 +15,6 @@
  */
 package de.cuioss.portal.core.cdi.support;
 
-@SuppressWarnings("javadoc")
 public interface TestInterface {
 
     String getInitMessage();

modules/core/portal-core/src/test/java/de/cuioss/portal/core/servlet/MockPortalServlet.java

@@ -26,7 +26,6 @@
 import lombok.Getter;
 import lombok.Setter;
 
-@SuppressWarnings("javadoc")
 @ApplicationScoped
 public class MockPortalServlet extends AbstractPortalServlet {
 

modules/test/portal-core-unit-testing/src/main/java/de/cuioss/portal/core/test/junit5/mockwebserver/MockWebServerExtension.java

@@ -45,7 +45,7 @@ public class MockWebServerExtension implements TestInstancePostProcessor, AfterE
      */
     public static final Namespace NAMESPACE = Namespace.create("test", "portal", "MockWebServer");
 
-    @SuppressWarnings({ "resource", "squid:S2095" }) // owolff: Will be closed after all tests
+    @SuppressWarnings({ "squid:S2095" }) // owolff: Will be closed after all tests
     @Override
     public void postProcessTestInstance(Object testInstance, ExtensionContext context) throws Exception {
 
@@ -66,7 +66,6 @@ public void postProcessTestInstance(Object testInstance, ExtensionContext contex
         put(mockWebServer, context);
     }
 
-    @SuppressWarnings("resource") // mock-system, should therefore not a problem
     @Override
     public void afterEach(ExtensionContext context) throws Exception {
         var server = get(context);

modules/test/portal-core-unit-testing/src/test/java/de/cuioss/portal/core/test/junit5/mockwebserver/dispatcher/AllOkDispatcher.java

@@ -23,7 +23,6 @@
 import mockwebserver3.MockResponse;
 import mockwebserver3.RecordedRequest;
 
-@SuppressWarnings("javadoc")
 public class AllOkDispatcher implements ModuleDispatcherElement {
 
     public static final String BASE = "/allOk";

modules/test/portal-core-unit-testing/src/test/java/de/cuioss/portal/core/test/junit5/mockwebserver/dispatcher/PassThroughDispatcher.java

@@ -15,7 +15,6 @@
  */
 package de.cuioss.portal.core.test.junit5.mockwebserver.dispatcher;
 
-@SuppressWarnings("javadoc")
 public class PassThroughDispatcher implements ModuleDispatcherElement {
 
     public static final String BASE = "/pass";

modules/test/portal-core-unit-testing/src/test/java/de/cuioss/portal/core/test/tests/configuration/ConfigurationKeys.java

@@ -17,7 +17,6 @@
 
 import lombok.experimental.UtilityClass;
 
-@SuppressWarnings("javadoc")
 @UtilityClass
 public class ConfigurationKeys {