Sonar Findings, unit-tests

modules/cui-jsf-api/src/test/java/de/cuioss/jsf/api/application/projectstage/CuiProjectStageImplTest.java

@@ -8,8 +8,6 @@
 
 import org.junit.jupiter.api.Test;
 
-import de.cuioss.jsf.api.application.projectstage.CuiProjectStageAccessor;
-import de.cuioss.jsf.api.application.projectstage.CuiProjectStageImpl;
 import de.cuioss.test.generator.Generators;
 import de.cuioss.test.generator.TypedGenerator;
 import de.cuioss.test.jsf.junit5.JsfEnabledTestEnvironment;

modules/cui-jsf-api/src/test/java/de/cuioss/jsf/api/components/model/menu/NavigationMenuItemContainerImplTest.java

@@ -1,11 +1,28 @@
 package de.cuioss.jsf.api.components.model.menu;
 
-import de.cuioss.jsf.api.components.model.menu.NavigationMenuItemContainerImpl;
+import static de.cuioss.test.generator.Generators.letterStrings;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+
+import org.junit.jupiter.api.Test;
+
+import de.cuioss.jsf.api.CoreJsfTestConfiguration;
+import de.cuioss.test.jsf.config.JsfTestConfiguration;
+import de.cuioss.test.jsf.junit5.EnableJsfEnvironment;
 import de.cuioss.test.valueobjects.ValueObjectTest;
 import de.cuioss.test.valueobjects.api.contracts.VerifyConstructor;
 import de.cuioss.test.valueobjects.api.generator.PropertyGenerator;
 
 @VerifyConstructor(of = "order")
 @PropertyGenerator(NavigationMenuItemGenerator.class)
+@EnableJsfEnvironment
+@JsfTestConfiguration(CoreJsfTestConfiguration.class)
 class NavigationMenuItemContainerImplTest extends ValueObjectTest<NavigationMenuItemContainerImpl> {
+
+    @Test
+    void shouldResolveLabelValue() {
+        var underTest = new NavigationMenuItemContainerImpl(1);
+        var value = letterStrings(1, 10).next();
+        underTest.setLabelValue(value);
+        assertEquals(value, underTest.getResolvedLabel());
+    }
 }

modules/cui-jsf-api/src/test/java/de/cuioss/jsf/api/components/model/menu/NavigationMenuItemExternalSingleImplTest.java

@@ -0,0 +1,64 @@
+package de.cuioss.jsf.api.components.model.menu;
+
+import static de.cuioss.test.generator.Generators.letterStrings;
+import static de.cuioss.tools.collect.CollectionLiterals.immutableList;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertFalse;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+
+import org.junit.jupiter.api.Test;
+
+import de.cuioss.jsf.api.CoreJsfTestConfiguration;
+import de.cuioss.test.jsf.config.JsfTestConfiguration;
+import de.cuioss.test.jsf.junit5.EnableJsfEnvironment;
+import de.cuioss.test.valueobjects.ValueObjectTest;
+import de.cuioss.test.valueobjects.api.contracts.VerifyConstructor;
+
+@VerifyConstructor(of = "order")
+@EnableJsfEnvironment
+@JsfTestConfiguration(CoreJsfTestConfiguration.class)
+class NavigationMenuItemExternalSingleImplTest extends ValueObjectTest<NavigationMenuItemExternalSingleImpl> {
+
+    @Test
+    void shouldResolveLabelValue() {
+        var underTest = new NavigationMenuItemExternalSingleImpl(1);
+        var value = letterStrings(1, 10).next();
+        underTest.setLabelValue(value);
+        assertEquals(value, underTest.getResolvedLabel());
+    }
+
+    @Test
+    void shouldResolveTitle() {
+        var underTest = new NavigationMenuItemExternalSingleImpl(1);
+        var value = letterStrings(1, 10).next();
+        underTest.setTitleValue(value);
+        assertEquals(value, underTest.getResolvedTitle());
+    }
+
+    @Test
+    void shouldDetectTitle() {
+        var underTest = new NavigationMenuItemExternalSingleImpl(1);
+        assertFalse(underTest.isTitleAvailable());
+        var value = letterStrings(1, 10).next();
+        underTest.setTitleValue(value);
+        assertTrue(underTest.isTitleAvailable());
+        assertEquals(value, underTest.getResolvedTitle());
+    }
+
+    @Test
+    void shouldCompareCorrectly() {
+        var one = new NavigationMenuItemExternalSingleImpl(1);
+        var two = new NavigationMenuItemExternalSingleImpl(2);
+        assertEquals(-1, one.compareTo(two));
+    }
+
+    @Test
+    void shouldDetectActiveView() {
+        var one = new NavigationMenuItemExternalSingleImpl(1);
+        assertFalse(one.isActive());
+
+        one.setActiveForAdditionalViewId(immutableList("myview"));
+        assertFalse(one.isActive());
+    }
+
+}

modules/cui-jsf-api/src/test/java/de/cuioss/jsf/api/components/model/menu/NavigationMenuItemGenerator.java

@@ -4,10 +4,6 @@
 
 import java.util.List;
 
-import de.cuioss.jsf.api.components.model.menu.NavigationMenuItem;
-import de.cuioss.jsf.api.components.model.menu.NavigationMenuItemContainerImpl;
-import de.cuioss.jsf.api.components.model.menu.NavigationMenuItemSeparatorImpl;
-import de.cuioss.jsf.api.components.model.menu.NavigationMenuItemSingleImpl;
 import de.cuioss.test.generator.Generators;
 import de.cuioss.test.generator.TypedGenerator;
 

modules/cui-jsf-api/src/test/java/de/cuioss/jsf/api/components/model/menu/NavigationMenuItemSeparatorImplTest.java

@@ -1,6 +1,5 @@
 package de.cuioss.jsf.api.components.model.menu;
 
-import de.cuioss.jsf.api.components.model.menu.NavigationMenuItemSeparatorImpl;
 import de.cuioss.test.valueobjects.ValueObjectTest;
 import de.cuioss.test.valueobjects.api.contracts.VerifyConstructor;
 import de.cuioss.test.valueobjects.api.generator.PropertyGenerator;

modules/cui-jsf-api/src/test/java/de/cuioss/jsf/api/components/model/menu/NavigationMenuItemSingleImplTest.java

@@ -1,11 +1,28 @@
 package de.cuioss.jsf.api.components.model.menu;
 
-import de.cuioss.jsf.api.components.model.menu.NavigationMenuItemSingleImpl;
+import static de.cuioss.test.generator.Generators.letterStrings;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+
+import org.junit.jupiter.api.Test;
+
+import de.cuioss.jsf.api.CoreJsfTestConfiguration;
+import de.cuioss.test.jsf.config.JsfTestConfiguration;
+import de.cuioss.test.jsf.junit5.EnableJsfEnvironment;
 import de.cuioss.test.valueobjects.ValueObjectTest;
 import de.cuioss.test.valueobjects.api.contracts.VerifyConstructor;
 import de.cuioss.test.valueobjects.api.generator.PropertyGenerator;
 
 @VerifyConstructor(of = "order")
 @PropertyGenerator(NavigationMenuItemGenerator.class)
+@EnableJsfEnvironment
+@JsfTestConfiguration(CoreJsfTestConfiguration.class)
 class NavigationMenuItemSingleImplTest extends ValueObjectTest<NavigationMenuItemSingleImpl> {
+
+    @Test
+    void shouldResolveLabelValue() {
+        var underTest = new NavigationMenuItemSingleImpl(1);
+        var value = letterStrings(1, 10).next();
+        underTest.setLabelValue(value);
+        assertEquals(value, underTest.getResolvedLabel());
+    }
 }

modules/cui-jsf-api/src/test/java/de/cuioss/jsf/api/converter/ComplexHtmlSanitizingConverterTest.java

@@ -1,6 +1,5 @@
 package de.cuioss.jsf.api.converter;
 
-import de.cuioss.jsf.api.converter.ComplexHtmlSanitizingConverter;
 import de.cuioss.test.jsf.converter.AbstractConverterTest;
 import de.cuioss.test.jsf.converter.TestItems;
 

modules/cui-jsf-api/src/test/java/de/cuioss/jsf/api/converter/FallbackSanitizingConverterTest.java

@@ -8,7 +8,6 @@
 import org.junit.jupiter.api.Test;
 
 import de.cuioss.jsf.api.application.projectstage.CuiProjectStageAccessor;
-import de.cuioss.jsf.api.converter.FallbackSanitizingConverter;
 import de.cuioss.test.jsf.junit5.JsfEnabledTestEnvironment;
 import de.cuioss.test.juli.LogAsserts;
 import de.cuioss.test.juli.TestLogLevel;

modules/cui-jsf-api/src/test/java/de/cuioss/jsf/api/converter/nameprovider/DisplayMessageProviderConverterTest.java

@@ -1,7 +1,6 @@
 package de.cuioss.jsf.api.converter.nameprovider;
 
 import de.cuioss.jsf.api.CoreJsfTestConfiguration;
-import de.cuioss.jsf.api.converter.nameprovider.DisplayMessageProviderConverter;
 import de.cuioss.test.jsf.config.JsfTestConfiguration;
 import de.cuioss.test.jsf.converter.AbstractConverterTest;
 import de.cuioss.test.jsf.converter.TestItems;

modules/cui-jsf-api/src/test/java/de/cuioss/jsf/api/converter/nameprovider/DisplayNameConverterTest.java

@@ -1,7 +1,6 @@
 package de.cuioss.jsf.api.converter.nameprovider;
 
 import de.cuioss.jsf.api.CoreJsfTestConfiguration;
-import de.cuioss.jsf.api.converter.nameprovider.DisplayNameConverter;
 import de.cuioss.test.generator.Generators;
 import de.cuioss.test.jsf.config.JsfTestConfiguration;
 import de.cuioss.test.jsf.converter.AbstractSanitizingConverterTest;

modules/cui-jsf-api/src/test/java/de/cuioss/jsf/api/converter/nameprovider/I18nDisplayNameProviderConverterTest.java

@@ -3,7 +3,6 @@
 import java.util.Locale;
 
 import de.cuioss.jsf.api.CoreJsfTestConfiguration;
-import de.cuioss.jsf.api.converter.nameprovider.I18nDisplayNameProviderConverter;
 import de.cuioss.test.jsf.config.JsfTestConfiguration;
 import de.cuioss.test.jsf.converter.AbstractSanitizingConverterTest;
 import de.cuioss.test.jsf.converter.TestItems;

modules/cui-jsf-api/src/test/java/de/cuioss/jsf/api/converter/nameprovider/LabeledKeyConverterTest.java

@@ -3,7 +3,6 @@
 import static de.cuioss.tools.collect.CollectionLiterals.immutableList;
 
 import de.cuioss.jsf.api.CoreJsfTestConfiguration;
-import de.cuioss.jsf.api.converter.nameprovider.LabeledKeyConverter;
 import de.cuioss.test.jsf.config.JsfTestConfiguration;
 import de.cuioss.test.jsf.converter.AbstractConverterTest;
 import de.cuioss.test.jsf.converter.TestItems;