Applying IDE-Fixes

cuioss · Mar 24, 2024 · e0f7f58 · e0f7f58
1 parent 3e65b44
commit e0f7f58
Show file tree

Hide file tree

Showing 10 changed files with 4 additions and 12 deletions.
diff --git a/src/main/java/de/cuioss/tools/codec/DecoderException.java b/src/main/java/de/cuioss/tools/codec/DecoderException.java
@@ -39,7 +39,6 @@ public class DecoderException extends Exception {
      *
      */
     public DecoderException() {
-        super();
     }
 
     /**

diff --git a/src/main/java/de/cuioss/tools/codec/EncoderException.java b/src/main/java/de/cuioss/tools/codec/EncoderException.java
@@ -39,7 +39,6 @@ public class EncoderException extends Exception {
      * {@link #initCause}.
      */
     public EncoderException() {
-        super();
     }
 
     /**

diff --git a/src/main/java/de/cuioss/tools/collect/CollectionBuilder.java b/src/main/java/de/cuioss/tools/collect/CollectionBuilder.java
@@ -107,7 +107,6 @@ public final class CollectionBuilder<E> implements Iterable<E> {
      * @param collector to be used for storage. Must not be null
      */
     public CollectionBuilder(Collection<E> collector) {
-        super();
         this.collector = requireNonNull(collector);
     }
 

diff --git a/src/main/java/de/cuioss/tools/formatting/SimpleFormatter.java b/src/main/java/de/cuioss/tools/formatting/SimpleFormatter.java
@@ -106,7 +106,7 @@ private String getJoined(final List<String> values) {
         if (isEmpty(values)) {
             return null;
         }
-        List<String> filtered = values.stream().filter(element -> !isEmpty(element)).toList();
+        var filtered = values.stream().filter(element -> !isEmpty(element)).toList();
         if (isEmpty(filtered)) {
             return null;
         }

diff --git a/src/main/java/de/cuioss/tools/formatting/template/token/ActionToken.java b/src/main/java/de/cuioss/tools/formatting/template/token/ActionToken.java
@@ -73,7 +73,7 @@ public String substituteAttribute(final FormatterSupport content) {
                 "AvailablePropertyValues must not be null. ");
         final var result = new StringBuilder();
         if (attributeValues.containsKey(attribute)) {
-            if (attributeValues.keySet().size() > 1) {
+            if (attributeValues.size() > 1) {
                 result.append(before).append(attributeValues.get(attribute)).append(after);
             } else {
                 // special case : if only one value exists no stored before + after are needed

diff --git a/src/main/java/de/cuioss/tools/logging/LogRecordModel.java b/src/main/java/de/cuioss/tools/logging/LogRecordModel.java
@@ -83,7 +83,6 @@ public String resolveIdentifierString() {
 
     @Builder
     private LogRecordModel(@NonNull String prefix, @NonNull Integer identifier, @NonNull String template) {
-        super();
         this.prefix = prefix;
         this.identifier = identifier;
         this.template = template;

diff --git a/src/main/java/de/cuioss/tools/net/UrlParameter.java b/src/main/java/de/cuioss/tools/net/UrlParameter.java
@@ -94,7 +94,6 @@ public UrlParameter(final String name, final String value) {
      *               UTF-8
      */
     public UrlParameter(final String name, final String value, final boolean encode) {
-        super();
         requireNotEmptyTrimmed(name, "Parameter name must not be empty");
         if (encode) {
             this.name = encode(name, StandardCharsets.UTF_8);

diff --git a/src/test/java/de/cuioss/tools/lang/MoreArraysTest.java b/src/test/java/de/cuioss/tools/lang/MoreArraysTest.java
@@ -68,7 +68,7 @@ void shouldDetermineEmptyIntArray() {
     void shouldDetermineEmptyLongArray() {
         assertTrue(MoreArrays.isEmpty((long[]) null));
         assertTrue(MoreArrays.isEmpty(new long[0]));
-        assertFalse(MoreArrays.isEmpty(new long[] { 1l }));
+        assertFalse(MoreArrays.isEmpty(new long[] { 1L }));
     }
 
     @Test

diff --git a/src/test/java/de/cuioss/tools/net/ssl/KeyStoreProviderTest.java b/src/test/java/de/cuioss/tools/net/ssl/KeyStoreProviderTest.java
@@ -222,10 +222,8 @@ private X509Certificate createX509Certificate(String algorithm, int keysize, Str
 
         var signer = new JcaContentSignerBuilder(signatureAlgorithm).build(keyPair.getPrivate());
 
-        var x509Certificate = new JcaX509CertificateConverter().setProvider(new BouncyCastleProvider())
+        return new JcaX509CertificateConverter().setProvider(new BouncyCastleProvider())
                 .getCertificate(x509Builder.build(signer));
-
-        return x509Certificate;
     }
 
     @Test

diff --git a/src/test/java/de/cuioss/tools/property/support/GenericTypeWithLowerBoundType.java b/src/test/java/de/cuioss/tools/property/support/GenericTypeWithLowerBoundType.java
@@ -40,7 +40,6 @@ public class GenericTypeWithLowerBoundType<K extends Serializable, V extends Ser
      * @param key must not be {@code null}
      */
     public GenericTypeWithLowerBoundType(@NonNull final K key) {
-        super();
         this.key = key;
     }