#332 rounding down of passed percentage#380
Merged
davidjgoss merged 4 commits intocucumber:mainfrom Apr 24, 2025
Merged
Conversation
…ounding down and display of 1 decimal place
✅ Deploy Preview for cucumber-react-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
davidjgoss
reviewed
Apr 24, 2025
Contributor
davidjgoss
left a comment
davidjgoss
left a comment
There was a problem hiding this comment.
Thanks for putting this together @ed-snodgrass. To your questions:
I would like to know if folks think it should still only display round numbers
I think a single decimal place would be a good balance if you're up for changing that too.
and/or if it should only round down when between 99% and 100%
I think, especially when combined with 1 dp per above, always flooring will be fine.
Contributor
Author
|
I agree with one dp. I initially had it that way and then went back to round numbers just in case. I'll move that back to one. |
davidjgoss
approved these changes
Apr 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
The code was modified to round down rather than round up and to allow 1 decimal place
⚡️ What's your motivation?
Fixes #332
🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
I would like to know if folks think it should still only display round numbers and/or if it should only round down when between 99% and 100%
📋 Checklist:
This text was originally generated from a template, then edited by hand. You can modify the template here.