[.NET] Avoid allocation and improve parsing time #344
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
This PR optimises allocations and speed by
GherkinLine
IEnumerable
so thatList
can be used, this avoids re-creating and coping with explicitly sized arraysResults before:
Results after:
⚡️ What's your motivation?
This reduces parsing time by ~45% and allocations by ~45%.
🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
The removed
IGherkinLine
interface is used in the Reqnroll VisualStudio plugin (I haven't found other implementations on github). But the custom implementation HotfixLine is probably not needed anymore. At least the added regression tests will pass with the originalIGherkinLine
implementation from this repository.📋 Checklist: