Add Rails 8 compatibility #590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tagliala
commented
Nov 10, 2024
4 tasks
skelz0r
added a commit
to etalab/data_pass
that referenced
this pull request
Nov 12, 2024
* Remove obosolete dependency from 12/2023 which was a proof of concept at the time. * Fix deprecated ``` DEPRECATION WARNING: `to_time` will always preserve the full timezone rather than offset of the receiver in Rails 8.1. To opt in to the new behavior, set `config.active_support.to_time_preserves_timezone = :zone`. ``` * `cucumber-rails` was not ready for rails 8, point to branch with some config change (no feature changed) cucumber/cucumber-rails#590
skelz0r
added a commit
to etalab/data_pass
that referenced
this pull request
Nov 12, 2024
* Remove obosolete dependency from 12/2023 which was a proof of concept at the time. * Fix deprecated ``` DEPRECATION WARNING: `to_time` will always preserve the full timezone rather than offset of the receiver in Rails 8.1. To opt in to the new behavior, set `config.active_support.to_time_preserves_timezone = :zone`. ``` * `cucumber-rails` was not ready for rails 8, point to branch with some config change (no feature changed) cucumber/cucumber-rails#590 * `MalwareScan#analyzed_at` is a datetime, not an integer, which raises an error now in Rails 8
skelz0r
added a commit
to etalab/data_pass
that referenced
this pull request
Nov 12, 2024
* Remove obosolete dependency from 12/2023 which was a proof of concept at the time. * Fix deprecated ``` DEPRECATION WARNING: `to_time` will always preserve the full timezone rather than offset of the receiver in Rails 8.1. To opt in to the new behavior, set `config.active_support.to_time_preserves_timezone = :zone`. ``` * `cucumber-rails` was not ready for rails 8, point to branch with some config change (no feature changed) cucumber/cucumber-rails#590 * `MalwareScan#analyzed_at` is a datetime, not an integer, which raises an error now in Rails 8
tagliala
force-pushed
the
feature/589-rails-8
branch
from
499545f
to
f1b892e
Compare
luke-hill
requested changes
Nov 13, 2024
tagliala
force-pushed
the
feature/589-rails-8
branch
from
f1b892e
to
b750833
Compare
mathieujobin
approved these changes
Nov 13, 2024
luke-hill
reviewed
Nov 21, 2024
In specific: - Do not test Rails 7.0 and 7.1 against 3.3 - Allow 8.0 in gemspec, by relaxing the upper constraint to `< 9`. Rails uses shifted SemVer, so `8.1` is considered a Major, but it has been decided to use `< 9` anyway - Conditionally load the sqlite3 gem based on the Rails version. - Conditionally load selenium webdriver gem based on the Rails version. - Simplify error page assertions to account for variations in apostrophes, as "We're sorry" changed to "We`re sorry" in Rails 8. References: - https://guides.rubyonrails.org/maintenance_policy.html#versioning - rails/rails#53045 Close cucumber#589
tagliala
force-pushed
the
feature/589-rails-8
branch
from
b750833
to
c7e99c4
Compare
luke-hill
approved these changes
Nov 21, 2024
tagliala
commented
Nov 21, 2024
| @@ -5,7 +5,7 @@ | |||
| [](https://codeclimate.com/github/cucumber/cucumber-rails) | |||
| [](https://www.codetriage.com/cucumber/cucumber-rails) | |||
|
|
|||
| Cucumber-Rails brings Cucumber to Rails 5.2, 6.x and 7.x. | |||
| Cucumber-Rails brings Cucumber to Rails 5.2, 6.x, 7.x, and 8.0. | |||
There was a problem hiding this comment.
Since the constraint is < 9, 8.0 may not play well with the gemspec but reflects actual compatibility
8.0 should be changed to 8.x after it is certain that cucumber-rails will also support 8.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In specific:
< 8.1.Rails uses shifted SemVer, so
8.1is considered a Major.apostrophes, as "We're sorry" changed to "We`re sorry" in Rails 8.
References:
Close #589
CI: https://github.com/tagliala/cucumber-rails/actions/runs/11764599692/job/32769937431
ActiveAdmin CI against the fork (7.0, 7.1, 7.2, 8.0): https://github.com/activeadmin/activeadmin/actions/runs/11764550754/job/32769831332
🤔 What's changed?
Rails 8.0 compatibility
⚡️ What's your motivation?
Unexpected downgrade to 1.4 after upgrading to Rails 8.x
🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
n/a
📋 Checklist:
This text was originally generated from a template, then edited by hand. You can modify the template here.