Skip to content

Fix/naming within junit test #3126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 2, 2025
+5 −5
Merged

Fix/naming within junit test #3126

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0eeedad
synchronize test-methode's name and result String
antagoony Dec 1, 2025
1d1b2c8
synchronize variable name and referred method's number of arguments
antagoony Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions ...er-java/src/test/java/io/cucumber/java/JavaDefaultParameterTransformerDefinitionTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ void must_have_two_arguments() throws Throwable {
}

public Object one_argument(String fromValue) {
return "one_arguments";
return "one_argument";
}

public Object three_arguments(String fromValue, Type toValueType, Object extra) {
Expand All @@ -88,10 +88,10 @@ public Object three_arguments(String fromValue, Type toValueType, Object extra)

@Test
void must_have_string_or_object_as_from_value() throws Throwable {
Method threeArg = JavaDefaultParameterTransformerDefinitionTest.class.getMethod("map_as_from_value", Map.class,
Method twoArg = JavaDefaultParameterTransformerDefinitionTest.class.getMethod("map_as_from_value", Map.class,
Type.class);
assertThrows(InvalidMethodSignatureException.class,
() -> new JavaDefaultParameterTransformerDefinition(threeArg, lookup));
() -> new JavaDefaultParameterTransformerDefinition(twoArg, lookup));
}

public Object map_as_from_value(Map<String, String> fromValue, Type toValueType) {
Expand All @@ -100,10 +100,10 @@ public Object map_as_from_value(Map<String, String> fromValue, Type toValueType)

@Test
void must_have_type_as_to_value_type() throws Throwable {
Method threeArg = JavaDefaultParameterTransformerDefinitionTest.class.getMethod("object_as_to_value_type",
Method twoArg = JavaDefaultParameterTransformerDefinitionTest.class.getMethod("object_as_to_value_type",
String.class, Object.class);
assertThrows(InvalidMethodSignatureException.class,
() -> new JavaDefaultParameterTransformerDefinition(threeArg, lookup));
() -> new JavaDefaultParameterTransformerDefinition(twoArg, lookup));
}

public Object object_as_to_value_type(String fromValue, Object toValueType) {
Expand Down
Loading