Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cubesql): Fix clippy warnings in cubesql, part 2 #9262

Merged
merged 14 commits into from
Feb 24, 2025

Conversation

mcheshkov
Copy link
Member

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Description of Changes Made (if issue reference is not provided)

Just a bunch of small clippy fixes around the codebase, targeted to enable more rules

@mcheshkov mcheshkov changed the title refactor(cubesql): Fix clippy warnings in cubesql, part 1 refactor(cubesql): Fix clippy warnings in cubesql, part 2 Feb 24, 2025
Copy link

codecov bot commented Feb 24, 2025

Codecov Report

Attention: Patch coverage is 29.34363% with 366 lines in your changes missing coverage. Please review.

Project coverage is 83.64%. Comparing base (e12dc44) to head (87123c5).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...sql/cubesql/src/compile/rewrite/rules/old_split.rs 0.00% 321 Missing ⚠️
.../cubesql/src/compile/engine/df/optimizers/utils.rs 8.69% 21 Missing ⚠️
rust/cubesql/cubesql/src/compile/engine/df/scan.rs 21.42% 11 Missing ⚠️
...besql/cubesql/src/compile/rewrite/rules/members.rs 76.47% 4 Missing ⚠️
rust/cubesql/cubesql/src/compile/plan.rs 0.00% 3 Missing ⚠️
...t/cubesql/cubesql/src/compile/engine/df/wrapper.rs 90.00% 1 Missing ⚠️
...t/cubesql/cubesql/src/compile/rewrite/converter.rs 95.65% 1 Missing ⚠️
...st/cubesql/cubesql/src/compile/rewrite/rewriter.rs 0.00% 1 Missing ⚠️
rust/cubesql/cubesql/src/sql/postgres/extended.rs 75.00% 1 Missing ⚠️
rust/cubesql/cubesql/src/sql/postgres/shim.rs 80.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9262      +/-   ##
==========================================
+ Coverage   83.57%   83.64%   +0.06%     
==========================================
  Files         227      227              
  Lines       81652    81576      -76     
==========================================
- Hits        68242    68234       -8     
+ Misses      13410    13342      -68     
Flag Coverage Δ
cubesql 83.64% <29.34%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mcheshkov mcheshkov marked this pull request as ready for review February 24, 2025 14:48
@mcheshkov mcheshkov requested a review from a team as a code owner February 24, 2025 14:48
Copy link
Member

@KSDaemon KSDaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 🔥

@mcheshkov mcheshkov merged commit 31a7a04 into master Feb 24, 2025
84 checks passed
@mcheshkov mcheshkov deleted the cubesql-clippy-2 branch February 24, 2025 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants