Skip to content

fix(schema-compiler): use ClickHouse String type in Tesseract casts (#10316) #11053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
igorlukanin wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −0
Open

fix(schema-compiler): use ClickHouse String type in Tesseract casts (#10316) #11053

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/cubejs-schema-compiler/src/adapter/ClickHouseQuery.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,6 +273,10 @@ export class ClickHouseQuery extends BaseQuery {
templates.quotes.escape = '\\`';
templates.types.boolean = 'BOOL';
templates.types.timestamp = 'DATETIME';
// ClickHouse's string type is `String` (case-sensitive); the base `STRING` is invalid.
// The legacy planner avoids this via castToString(), but Tesseract renders the types.string
// template directly, so it must be overridden here. See cube-js/cube#10316.
templates.types.string = 'String';
delete templates.types.time;
// ClickHouse intervals have a distinct type for each granularity
delete templates.types.interval;
Expand Down
Loading