Skip to content

fix(bigquery): align DATE() function output to TIMESTAMP for SQL API compatibility #10660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tlangton3 wants to merge 2 commits into
base: master
Choose a base branch
from
+28 −0
Open

fix(bigquery): align DATE() function output to TIMESTAMP for SQL API compatibility #10660

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b5b0404
fix(bigquery): align DATE() function output to TIMESTAMP for SQL API …
tlangton3 Apr 9, 2026
13c17cb
test(mssql): skip DATE() function tests unsupported on MSSQL
tlangton3 Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/cubejs-schema-compiler/src/adapter/BigqueryQuery.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ class BigqueryFilter extends BaseFilter {
public castParameter() {
if (this.definition().type === 'boolean') {
return 'CAST(? AS BOOL)';
} else if (this.definition().type === 'time') {
return 'CAST(? AS TIMESTAMP)';
} else if (this.measure || this.definition().type === 'number') {
// TODO here can be measure type of string actually
return 'CAST(? AS FLOAT64)';
Expand Down Expand Up @@ -347,6 +349,7 @@ export class BigqueryQuery extends BaseQuery {
// DATEADD is being rewritten to DATE_ADD
templates.functions.DATE_ADD = 'DATETIME_ADD(DATETIME({{ args[0] }}), INTERVAL {{ interval }} {{ date_part }})';
templates.functions.CURRENTDATE = 'CURRENT_DATE';
templates.functions.DATE = 'TIMESTAMP({{ args_concat }})';
delete templates.functions.TO_CHAR;
delete templates.functions.PERCENTILECONT;
templates.expressions.binary = '{% if op == \'%\' %}MOD({{ left }}, {{ right }}){% else %}({{ left }} {{ op }} {{ right }}){% endif %}';
Expand Down
4 changes: 4 additions & 0 deletions packages/cubejs-testing-drivers/fixtures/mssql.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,8 @@
"SQL API: SQL push down push to cube quoted alias",
"SQL API: Date/time comparison with SQL push down",
"SQL API: Date/time comparison with date_trunc with SQL push down",
"SQL API: Date/time comparison with DATE() function in SQL push down",
"SQL API: Date/time comparison with DATE() function using COUNT push down",

"---------------------------------------",
"Error during rewrite: Can't detect Cube query and it may be not supported yet.",
Expand Down Expand Up @@ -228,6 +230,8 @@
"SQL API: SQL push down push to cube quoted alias",
"SQL API: Date/time comparison with SQL push down",
"SQL API: Date/time comparison with date_trunc with SQL push down",
"SQL API: Date/time comparison with DATE() function in SQL push down",
"SQL API: Date/time comparison with DATE() function using COUNT push down",

"---------------------------------------",
"Error during rewrite: Can't detect Cube query and it may be not supported yet.",
Expand Down
21 changes: 21 additions & 0 deletions packages/cubejs-testing-drivers/src/tests/testQueries.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2610,5 +2610,26 @@ from
`);
expect(res.rows).toMatchSnapshot();
});

executePg('SQL API: Date/time comparison with DATE() function in SQL push down', async (connection) => {
const res = await connection.query(`
SELECT MEASURE(BigECommerce.totalQuantity) as qty
FROM BigECommerce
WHERE CAST(BigECommerce.orderDate AS DATE) = DATE('2020-01-01')
`);
expect(res.rows).toMatchSnapshot();
});

executePg('SQL API: Date/time comparison with DATE() function using COUNT push down', async (connection) => {
const res = await connection.query(`
SELECT
CAST(BigECommerce.orderDate AS DATE) as order_day,
COUNT(1) as cnt
FROM BigECommerce
WHERE CAST(BigECommerce.orderDate AS DATE) = DATE('2020-01-01')
GROUP BY 1
`);
expect(res.rows).toMatchSnapshot();
});
});
}
Loading