fix(tesseract): preserve FILTER_PARAMS pushdown with segments#10608
Open
hank-sq wants to merge 1 commit intocube-js:masterfrom
Open
fix(tesseract): preserve FILTER_PARAMS pushdown with segments#10608hank-sq wants to merge 1 commit intocube-js:masterfrom
hank-sq wants to merge 1 commit intocube-js:masterfrom
Conversation
github-actions
bot
added
rust
hank-sq
force-pushed
the
hank/fix-filter-params-segment-pushdown
branch
from
cf9a4f2 to
17b673e
Compare
hank-sq
force-pushed
the
hank/fix-filter-params-segment-pushdown
branch
from
17b673e to
bc44874
Compare
hank-sq
force-pushed
the
hank/fix-filter-params-segment-pushdown
branch
from
bc44874 to
af829a3
Compare
Tesseract was treating any segment inside a filter tree as a fatal subtree extraction failure, which made FILTER_PARAMS fall back to always_true(). Keep AND-group pruning for matching members, require full matches for OR groups, and add regressions for segment siblings and partial OR branches. Made-with: Cursor
hank-sq
force-pushed
the
hank/fix-filter-params-segment-pushdown
branch
from
af829a3 to
32ab6a8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FILTER_PARAMSsubtree extraction working when anANDgroup includes segment filters alongside matching member filtersORgroups so we never prune a branch and change boolean semanticsORbranchesCloses #10606.
Test plan
docker run --rm -v \"/Users/hank/Development/tmp/cube-filterparams-fix:/work\" -w /work/rust/cubesqlplanner rust:1.90.0 cargo test -p cubesqlplanner test_find_subtree_for_members -- --nocapturedocker run --rm -v \"/Users/hank/Development/tmp/cube-filterparams-fix:/work\" -w /work/rust/cubesqlplanner rust:1.90.0 cargo test -p cubesqlplanner tests::filter -- --nocaptureMade with Cursor