feat: Support pre-aggregation-specific data source credentials (CORE-…

[ovr]

No description provided.

[claude]

Suggestion: Consider adding a unit test for edge cases in the regex. The regex ^(CUBEJS_DS_[A-Z0-9_]+?_)(DB_|JDBC_|AWS_|DATABASE|FIREBOLT_)(.*) uses a non-greedy match for the DS name which could behave unexpectedly with certain datasource names.

For example, a datasource named db would produce the key CUBEJS_DS_DB_DB_HOST. The non-greedy [A-Z0-9_]+?_ would match CUBEJS_DS_D first, then try B_DB_HOST against the alternation — B_ doesn't match DB_, so it extends to CUBEJS_DS_DB_ and then matches DB_HOST. This works, but edge cases like datasource names containing DB, AWS, JDBC, etc. as substrings should be tested.

Also, DATABASE in the alternation doesn't have a trailing underscore. For CUBEJS_DS_FOO_DATABASE_SECRET_ARN, group 2 captures DATABASE and group 3 captures _SECRET_ARN (including the leading underscore). This produces CUBEJS_DS_FOO_PRE_AGGREGATIONS_DATABASE_SECRET_ARN which is correct, but the asymmetry with other alternatives (which have trailing _) is subtle.

[codecov]

Codecov Report

❌ Patch coverage is 68.20513% with 62 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.94%. Comparing base (cec71d6) to head (1cf720c).
⚠️ Report is 2 commits behind head on master.

Files with missing lines	Patch %	Lines
packages/cubejs-backend-shared/src/env.ts	68.38%	43 Missing ⚠️
...y-orchestrator/src/orchestrator/PreAggregations.ts	40.00%	6 Missing ⚠️
...s/cubejs-clickhouse-driver/src/ClickHouseDriver.ts	63.63%	0 Missing and 4 partials ⚠️
packages/cubejs-druid-driver/src/DruidDriver.ts	20.00%	3 Missing and 1 partial ⚠️
packages/cubejs-base-driver/src/BaseDriver.ts	0.00%	2 Missing ⚠️
...kages/cubejs-bigquery-driver/src/BigQueryDriver.ts	33.33%	0 Missing and 2 partials ⚠️
packages/cubejs-server-core/src/core/server.ts	94.11%	0 Missing and 1 partial ⚠️

❗ There is a different number of reports uploaded between BASE (cec71d6) and HEAD (1cf720c). Click for more details.

HEAD has 1 upload less than BASE

Flag	BASE (cec71d6)	HEAD (1cf720c)
cubesql	1	0

Additional details and impacted files

@@             Coverage Diff             @@
##           master   #10587       +/-   ##
===========================================
- Coverage   83.40%   57.94%   -25.47%     
===========================================
  Files         250      215       -35     
  Lines       75261    16639    -58622     
  Branches        0     3345     +3345     
===========================================
- Hits        62775     9641    -53134     
+ Misses      12486     6509     -5977     
- Partials        0      489      +489     

Flag	Coverage Δ
cube-backend	57.94% <68.20%> (?)
cubesql	?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.