fix(schema-compiler): Do not collect disabled external pre-aggregations #10014
+41
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MazterQyou
force-pushed
the
api-gateway/sql-push-down-no-preaggs
branch
2 times, most recently
from
11f5bb6 to
c4a599b
Compare
MazterQyou
changed the title
MazterQyou
force-pushed
the
api-gateway/sql-push-down-no-preaggs
branch
from
c4a599b to
e77ac27
Compare
MazterQyou
changed the title
MazterQyou
force-pushed
the
api-gateway/sql-push-down-no-preaggs
branch
2 times, most recently
from
6697863 to
42df50b
Compare
waralexrom
approved these changes
Oct 1, 2025
MazterQyou
force-pushed
the
api-gateway/sql-push-down-no-preaggs
branch
from
42df50b to
d0ea909
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #10014 +/- ##
==========================================
+ Coverage 83.16% 83.19% +0.02%
==========================================
Files 244 244
Lines 73249 73429 +180
==========================================
+ Hits 60916 61087 +171
- Misses 12333 12342 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
MazterQyou
force-pushed
the
api-gateway/sql-push-down-no-preaggs
branch
from
d0ea909 to
ff90238
Compare
Signed-off-by: Alex Qyoun-ae <[email protected]>
MazterQyou
force-pushed
the
api-gateway/sql-push-down-no-preaggs
branch
from
ff90238 to
4236893
Compare
KSDaemon
reviewed
Oct 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
Description of Changes Made
This PR resolves an issue with SQL push down queries having pre-aggregation description which let it bypass rollup-only mode and get registered as a pre-aggregated query.