Skip to content

Conversation

MazterQyou
Copy link
Member

@MazterQyou MazterQyou commented Sep 29, 2025

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Description of Changes Made

This PR fixes an issue with 8398538 when an inverted year-month filter did not match as CubeScan filter. The rules are more universal to catch more ranges. Related test is included.

@MazterQyou MazterQyou requested a review from a team as a code owner September 29, 2025 12:48
Copy link

codecov bot commented Sep 29, 2025

Codecov Report

❌ Patch coverage is 90.50847% with 28 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.43%. Comparing base (9274201) to head (7a72efa).
⚠️ Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
...besql/cubesql/src/compile/rewrite/rules/filters.rs 88.36% 27 Missing ⚠️
rust/cubesql/cubesql/src/compile/mod.rs 98.41% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10009      +/-   ##
==========================================
+ Coverage   83.41%   83.43%   +0.02%     
==========================================
  Files         258      258              
  Lines       75150    75330     +180     
==========================================
+ Hits        62687    62853     +166     
- Misses      12463    12477      +14     
Flag Coverage Δ
cubesql 83.43% <90.50%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MazterQyou MazterQyou force-pushed the cubesql/tableau-extract-year-month-rev branch from 7c43db3 to 7a72efa Compare September 30, 2025 16:49
@MazterQyou MazterQyou merged commit d2e67ad into master Oct 1, 2025
84 checks passed
@MazterQyou MazterQyou deleted the cubesql/tableau-extract-year-month-rev branch October 1, 2025 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants