Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store subarray description in the output file of the stats tool #2696

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

TjarkMiener
Copy link
Member

We noticed that we would like to run an additional custom OutlierDetectors based on the deviation from the expected standard deviation of the number of photoelectrons in the calibpipe ffactor tool (see e.g. calibpipe-MR). Therefore we need the SubarrayDescription in the output file of the stats tool since the OutlierDetectors are TelescopeComponents.

@TjarkMiener TjarkMiener requested review from maxnoe and kosack February 12, 2025 08:19

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

use default naming for selected subarray

This comment has been minimized.

@TjarkMiener TjarkMiener requested a review from maxnoe February 14, 2025 09:42
Copy link
Member

@maxnoe maxnoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test (or a line to the existing one) that reads the sub array back

maxnoe
maxnoe previously approved these changes Feb 14, 2025

This comment has been minimized.

1 similar comment
Copy link

Passed

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage 100.00% Coverage (94.20% Estimated after merge)
  • Duplications 0.00% Duplicated Code (0.70% Estimated after merge)

Project ID: cta-observatory_ctapipe_AY52EYhuvuGcMFidNyUs

View in SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants