clippy: do not fail scan of packages without Rust code #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdudka
added a commit
to kdudka/csmock
that referenced
this pull request
May 28, 2024
We want to enable `clippy` in the default scanning profile in a way that it takes an effect for packages that build Rust code. For packages that do not build any Rust code, the plug-in should do nothing rather than failing the whole scan: ``` % csmock -at clippy -r rhel-7-x86_64 -f units-2.01-5.el7_9.src.rpm [...] >>> 2024-05-28 12:24:21 "set -o pipefail; /usr/share/csmock/scripts/convert-clippy.py < /tmp/csmocknsbuwvil/units-2.01-5.el7_9/debug/raw-results/builddir/clippy-output.txt | csgrep --remove-duplicates > /tmp/csmocknsbuwvil/units-2.01-5.el7_9/debug/uni-results/clippy-capture.err" /bin/sh: line 1: /tmp/csmocknsbuwvil/units-2.01-5.el7_9/debug/raw-results/builddir/clippy-output.txt: No such file or directory !!! 2024-05-28 12:24:21 error: post-process hook failed ``` Fixes: commit d216903 Related: https://issues.redhat.com/browse/OSH-30 Closes: csutils#169
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
We want to enable `clippy` in the default scanning profile in a way that it takes an effect for packages that build Rust code. For packages that do not build any Rust code, the plug-in should do nothing rather than failing the whole scan: ``` % csmock -at clippy -r rhel-7-x86_64 -f units-2.01-5.el7_9.src.rpm [...] >>> 2024-05-28 12:24:21 "set -o pipefail; /usr/share/csmock/scripts/convert-clippy.py < /tmp/csmocknsbuwvil/units-2.01-5.el7_9/debug/raw-results/builddir/clippy-output.txt | csgrep --remove-duplicates > /tmp/csmocknsbuwvil/units-2.01-5.el7_9/debug/uni-results/clippy-capture.err" /bin/sh: line 1: /tmp/csmocknsbuwvil/units-2.01-5.el7_9/debug/raw-results/builddir/clippy-output.txt: No such file or directory !!! 2024-05-28 12:24:21 error: post-process hook failed ``` Fixes: commit d216903 Related: https://issues.redhat.com/browse/OSH-30 Closes: csutils#169
lzaoral
approved these changes
May 28, 2024
|
@lzaoral Thanks for review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to enable
clippyin the default scanning profile in a way that it takes an effect for packages that build Rust code. For packages that do not build any Rust code, the plug-in should do nothing rather than failing the whole scan:Fixes: commit d216903
Related: https://issues.redhat.com/browse/OSH-30