-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
csmock: use the root mock profile property for lock names #151
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to cache the root_path
value in the MockWrapper
object so that it can be used at other places (e.g. in the semgrep
plug-in) without querying it again?
All suggestions addressed in or obsoleted by 87dfa62. |
9b24649
to
5a0d5c1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected now. Thanks!
To fix a crash when two mock profile configuration files have different names but use the same root directory: ``` [...] >>> 2024-02-19 14:29:12 "/usr/bin/mock" "-r" "/tmp/tmpyfvruenl/mock.cfg" "--plugin-option=tmpfs:keep_mounted=True" "--config-opts=print_main_output=True" "--init" INFO: mock.py version 5.2 starting (python version = 3.9.18, NVR = mock-5.2-1.kdudka.5.el9), args: /usr/libexec/mock/mock -r /tmp/tmpyfvruenl/mock.cfg --plugin-option=tmpfs:keep_mounted=True --config-opts=print_main_output=True --init Start(bootstrap): init plugins INFO: selinux enabled Finish(bootstrap): init plugins Start: init plugins INFO: selinux enabled Finish: init plugins INFO: Signal handler active Start: run Start: clean chroot ERROR: Build root is locked by another process. !!! 2024-02-19 14:29:13 warning: failed to init mock profile (/tmp/tmpyfvruenl/mock.cfg), trying to scrub cache... [...] ``` Resolves: openscanhub/openscanhub#228 (comment)
be08b57
to
b2c7201
Compare
To fix a crash when two mock profile configuration files have different names but use the same root directory:
Resolves: openscanhub/openscanhub#228 (comment)