json-writer: print level key in SARIF output
#81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdudka
requested changes
Aug 26, 2022
... so that users can easily filter results according to their severity. Fixes: csutils#80 Co-authored-by: Kamil Dudka <[email protected]> Co-authored-by: Lukáš Zaoral <[email protected]>
jamacku
approved these changes
Aug 26, 2022
lzaoral
commented
Sep 20, 2022
| @@ -214,6 +214,24 @@ static void sarifEncodeMsg(PTree *pDst, const std::string& text) | |||
| pDst->put_child("message", msg); | |||
| } | |||
|
|
|||
| static void sarifEncodeLevel(PTree *result, const std::string &event) { | |||
There was a problem hiding this comment.
Note to self: fix bracket formatting inconsistency in some future commit
There was a problem hiding this comment.
We might consider using this one-liner in CI to catch this:
grep '^static .*) *{$' src/*
There is one more inconsistency in abstarct-parser.cc:
src/abstract-parser.cc:static inline std::unique_ptr<T> make_unique(InStream &input) {
src/json-writer.cc:static void sarifEncodeLevel(PTree *result, const std::string &event) {
There was a problem hiding this comment.
Using a custom .clang-format config to enforce code style is would be a better solution. Tracked in #86.
There was a problem hiding this comment.
That would mean more work than the proposed one-liner. But if we have a volunteer to work on this, why not :-)
There was a problem hiding this comment.
It's not that hard, I've already done it few times. Additionally, such config file can be then used in all of our projects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... so that users can easily filter results according to their severity.
Fixes: #80