Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packaging: do not use %py_provides in epel-7 builds #203

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

kdudka
Copy link
Member

@kdudka kdudka commented Sep 9, 2024

If the buildroot contains outdated packages that do not yet contain definition of the macro, it causes the build of csdiff to fail with:

error: line 90: Unknown tag: %py_provides    python3-csdiff

This reverts commit df5c63f.

Fixes: commit f16db5a
Closes: #203

@kdudka kdudka requested a review from lzaoral September 9, 2024 14:54
@kdudka kdudka self-assigned this Sep 9, 2024
make-srpm.sh Show resolved Hide resolved
If the buildroot contains outdated packages that do not yet contain
definition of the macro, it causes the build of csdiff to fail with:
```
error: line 90: Unknown tag: %py_provides    python3-csdiff
```

This partially reverts commit df5c63f.

Fixes: commit f16db5a
Closes: csutils#203
Copy link
Member

@lzaoral lzaoral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @kdudka!

@kdudka kdudka changed the title packaging: do not use %py_provides for compatibility packaging: do not use %py_provides in epel-7 builds Sep 12, 2024
@kdudka kdudka changed the title packaging: do not use %py_provides in epel-7 builds packaging: do not use %py_provides in epel-7 builds Sep 12, 2024
@kdudka
Copy link
Member Author

kdudka commented Sep 12, 2024

@lzaoral Thanks for review!

@kdudka kdudka closed this in d1e25e8 Sep 12, 2024
@kdudka kdudka merged commit d1e25e8 into csutils:main Sep 12, 2024
24 of 32 checks passed
@kdudka kdudka deleted the py-provides branch September 12, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants