msg-filters: added filter for too-many event in csdiff #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jperezdealgaba
force-pushed
the
filter-many-events
branch
from
50e6d62
to
403347b
Compare
jperezdealgaba
force-pushed
the
filter-many-events
branch
from
403347b
to
3dc4967
Compare
lzaoral
requested changes
Jun 12, 2024
src/lib/msg-filter.cc
Outdated
| @@ -78,6 +78,8 @@ MsgFilter::MsgFilter(): | |||
| d(new Private) | |||
| { | |||
| d->addMsgFilter("", "[0-9][0-9]* out of [0-9][0-9]* times"); | |||
| // ignore error[too-many] events | |||
| d->addMsgFilter("", "[0-9]+ occurrences of warning\\[.*\\] exceeded the specified limit [0-9]+"); | |||
There was a problem hiding this comment.
While this make the diffs in tests the same, this change is wrong. This will combine all error[too-many] defects into a single warning regardless of the actual rate-limited warning!
Please, provide the third addMsgFilter argument with the proper replacement and also extend the new test with such inputs. Thank you!
jperezdealgaba
force-pushed
the
filter-many-events
branch
from
3dc4967
to
be1def4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: issues.redhat.com/browse/OSH-496
Added filter and test for error[too-many] findings in csdiff in order to apply the filter deterministically even if the location and the number of occurrences vary
This PR will should be in draft until following MR: #185 is merged