writer-json-sarif: add tool to rule properties #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No changes in behavior intended with this commit.
No changes in behavior intended with this commit.
No changes in behavior intended with this commit, except for reordering of unordered items in a JSON object.
... to ease SARIF import into Defect Dojo Resolves: https://issues.redhat.com/browse/OSH-355 Closes: csutils#147
kdudka
force-pushed
the
sarif-tool-tag
branch
from
9134876
to
bb1634e
Compare
|
@hanchuntao We have already a confirmation that the change improved the import into Defect Dojo. We would just need another pair of eyes to have a look at the code changes. Could you please take the review of this? |
hanchuntao
approved these changes
Oct 19, 2023
|
LGTM, please rebase the code |
|
@hanchuntao Thanks for review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... to ease SARIF import into Defect Dojo
Resolves: https://issues.redhat.com/browse/OSH-355