Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

csfilter: Ignore paths in 'profile count data file not found' warnings #146

Merged
merged 2 commits into from
Oct 9, 2023

Conversation

siteshwar
Copy link
Member

No description provided.

@siteshwar siteshwar marked this pull request as draft October 9, 2023 11:40
@siteshwar
Copy link
Member Author

@siteshwar siteshwar changed the title csfilter: Ignore profile count data file not found errors csfilter: Ignore 'profile count data file not found' warnings Oct 9, 2023
@kdudka
Copy link
Member

kdudka commented Oct 9, 2023

@siteshwar
Copy link
Member Author

@kdudka I believe this is ready to be merged. Let me know if I missed anything.

@siteshwar siteshwar marked this pull request as ready for review October 9, 2023 13:57
Copy link
Member

@kdudka kdudka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The newly added rule does nothing. The test you added is passing with/without the code change. The following patch fixes it:

--- a/src/lib/msg-filter.cc
+++ b/src/lib/msg-filter.cc
@@ -131,7 +131,9 @@ MsgFilter::MsgFilter():
             " on line [0-9]+\\.$", " on line NNNN.");

     // ignore profile count data file not found errors
-    d->addMsgFilter("COMPILER_WARNING", ": ‘.*’ profile count data file not found", "");
+    d->addMsgFilter("COMPILER_WARNING",
+            "‘.*’( profile count data file not found)",
+            "...\1");

     // pylint reports, either raw, or prospector-wrapped
     const std::string pylintCheckers = "PROSPECTOR_WARNING|PYLINT_WARNING";

Then you need to run sync.sh again to update the expected output in the test.

@kdudka kdudka changed the title csfilter: Ignore 'profile count data file not found' warnings csfilter: Ignore paths in 'profile count data file not found' warnings Oct 9, 2023
Copy link
Member

@kdudka kdudka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for the update!

@siteshwar siteshwar merged commit c753de1 into csutils:main Oct 9, 2023
6 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants