Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow up on "Web interface: design/accessibility issues" issue #174

Open
siteshwar opened this issue Apr 25, 2024 · 2 comments
Open

Follow up on "Web interface: design/accessibility issues" issue #174

siteshwar opened this issue Apr 25, 2024 · 2 comments
Labels
enhancement html

Comments

@siteshwar
Copy link
Member

This is a follow up on openscanhub/openscanhub#214.

As mentioned in the this comment, the report is generated through csdiff and should be fixed in writer-html.cc.
@siteshwar siteshwar mentioned this issue Apr 25, 2024
Closed
@kdudka
Copy link
Member

kdudka commented Apr 25, 2024

TL;DR The HTML writer needs to use CSS classes rather than inlining a style definition in each HTML tag separately.

@jamacku jamacku mentioned this issue May 10, 2024
Merged
jamacku added a commit to jamacku/csdiff that referenced this issue May 14, 2024
@jamacku
feat(cshtml): use CSS instead of inlining styles
5f3b933 
Fixes: csutils#174
Closes: csutils#181
jamacku added a commit to jamacku/csdiff that referenced this issue May 15, 2024
@jamacku
feat(cshtml): use CSS instead of inlining styles
1599a7c 
Fixes: csutils#174
Closes: csutils#181
@lzaoral
Copy link
Member

lzaoral commented May 15, 2024

I suggest to keep this opened because only a subset of the issues described in openscanhub/openscanhub#214 was resolved. The generated HTML report still uses a colour scheme which is too hard to read for some people.

@lzaoral lzaoral reopened this May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement html
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kdudka @siteshwar @jamacku @lzaoral