Conversation
|
When this is done, we can also remove the dev_2 and development branches to clean up a little. |
|
I am not quite sure why pylint fails, as it gave me a 10.0 score locally. It's probably a different pylint version or something. I will fix everything and try to reinstall pylint locally. |
|
I updated pylint, mypy, black, and pytest to the newest versions locally and everything runs fine. The pylint issues on github are due to pylint not recognizining the static typing correctly. Both locally and on github, pylint version 3.2.3 is run, so I have no idea why it does not work. |
|
Hey, thanks @pschultzendorff for the nice work, just a few things:
|
|
I swapped from ecl to resdata in the modules ml.ensemble and ml.ecl_dataset (now called ml.resdata_dataset). However, I won't fix all the examples as that is too much work. |
|
I took the chance to change test_plot_comparison to run on multiple results. Flow aborts the co2_eor simulation due to some reason, so I removed it from test_plot_comparison. test_co2_eor is still successful, because the UNRST file is created (but no summary file) |
|
It looks very good, thanks for the nice coding, merging :). |
Finally found time to fix everything.
Proposed changes
upscalingmodule which features aBaseUpscalerabstract base class, which provides methods to upscale data from fine-scale radial ensemble simulations to a coarse-scale Cartesian grid.analysismodule to analyze sensitivity of NNs w.r.t. their inputs.scaler_layersandnn.scale_and_evaluatetest_plot_comparisonruns only on one simulation result and not on multiple, I could change this though.standardwell_implandstandardwellmakos. They are kind of obsolete (I wrote new ones for the near-well article) and also very specific to a usecase, so I do not think they fit too well inside pyopmnearwell. In theintegrationmodule I link to the article repo for examplary usage.And probably some more small changes that I forgot about in this list.
Practicalities
Types of changes
What types of changes does this PR introduce to pyopmnearwell?
Checklist
pytestwas run with the--run-skippedflag.