Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debug wps outputs #20

Merged
merged 2 commits into from
Apr 19, 2023
Merged

Debug wps outputs #20

merged 2 commits into from
Apr 19, 2023

Conversation

haotanggg
Copy link

@haotanggg haotanggg commented Apr 19, 2023 •
edited
Loading

wrt #14

mpaget
mpaget approved these changes Apr 19, 2023
View reviewed changes
Copy link

@mpaget mpaget left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. Some print statements and if statements remain but we can address these as part of #19

@mpaget mpaget merged commit 07dddd2 into master Apr 19, 2023
@mpaget mpaget deleted the debug_wps_outputs branch April 19, 2023 01:17
@mpaget
Copy link

mpaget commented Apr 19, 2023

Closes #14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpaget mpaget mpaget approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haotanggg @mpaget