replication: add replication state to GetVolumeReplicationInfo response #77
Conversation
Nikhil-Ladha
force-pushed
the
add-state-to-info-api
branch
2 times, most recently
from
f7da44e to
34637e3
Compare
| } | ||
| // Represents the current replication status as reported by | ||
| // the backend storage system. | ||
| // This field is OPTIONAL. |
There was a problem hiding this comment.
Why is this OPTIONAL? Is the default not UNKNOWN so that it can be marked REQUIRED?
There was a problem hiding this comment.
If we make it required, then any SP that do not implement this change will by default start seeing the status as UNKNOWN, which maybe incorrect if everything is fine.
It would become a breaking change, isn't it?
There was a problem hiding this comment.
How should the difference between UNKNOWN and an unset .status be handled? I suspect that both are the same for anyone that inspects the result of the procedure call.
If there is a good reason to differentiate between unset and UNKNOWN, I agree that OPTIONAL makes sense.
There was a problem hiding this comment.
UNKNOWN can be returned if the mirroring is still being enabled, and not yet completed.
Or, if the mirroring state itself is unknown, i.e, up+unknown in case of ceph rbd.
Nikhil-Ladha
force-pushed
the
add-state-to-info-api
branch
from
34637e3 to
d0251af
Compare
…oResponse add status and status_message to GetVolumeReplicationInfoResponse that describes the current replication state to the end user. Signed-off-by: Nikhil-Ladha <[email protected]>
Nikhil-Ladha
force-pushed
the
add-state-to-info-api
branch
from
d0251af to
9c92b24
Compare
add
replication_stateto GetVolumeReplicationInfo response.Fixes: #78