merge queue: embarking main (e0d915c) and #519 together #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
Bumps [super-linter/super-linter](https://github.com/super-linter/super-linter) from 5 to 6. - [Release notes](https://github.com/super-linter/super-linter/releases) - [Changelog](https://github.com/super-linter/super-linter/blob/main/CHANGELOG.md) - [Commits](super-linter/super-linter@v5...v6) --- updated-dependencies: - dependency-name: super-linter/super-linter dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Without the GITHUB_TOKEN in the environment, the super-linter workflow fails to set the CI status in PR's. Signed-off-by: Niels de Vos <[email protected]>
Signed-off-by: Niels de Vos <[email protected]>
super-linter needs the full git history to get the list of files that changed across commits. Signed-off-by: Niels de Vos <[email protected]>
checkov is a linter for infrastructire as code, which we do not use in this repository. It detects an error under the `vendor/` directory, which should be skipped either way (filtering not working for this checker?). There is no need to run the checked for Go modules. We have other CI jobs that validate the Go modules already. Because parts of Kubernetes are vendored (which is large), the Go module checker times out. Signed-off-by: Niels de Vos <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 This pull request has been checked successfully and will be merged soon. 🎉
Branch main (e0d915c) and #519 are embarked together for merge.
This pull request has been created by Mergify to speculatively check the mergeability of #519.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.
Required conditions of queue
defaultfor merge:#approved-reviews-by>=2[🛡 GitHub branch protection]#changes-requested-reviews-by=0[🛡 GitHub branch protection]status-success=build_bundlestatus-success=build_controllerstatus-success=build_sidecarstatus-success=codespellstatus-success=go_mod_vendorstatus-success=go_mod_verifystatus-success=kind_deployRequired conditions to stay in the queue:
#approved-reviews-by>=2[🛡 GitHub branch protection]#changes-requested-reviews-by=0[🛡 GitHub branch protection]Visit the Mergify Dashboard to check the state of the queue
default.