Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code for #292 #293

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add code for #292 #293

wants to merge 1 commit into from

Conversation

Robinlovelace
Copy link
Collaborator

No description provided.

@csgillespie
Copy link
Owner

@Robinlovelace Nice additional, however, the code doesn't run for me. Also, what do you suggest about timing from vroom and lasy loading?

@Robinlovelace
Copy link
Collaborator Author

Was just a starter for 10. What do you mean by 'timing for lazy loading'? Happy to iterate, just trying to get things up-to-date. Another idea: should we print package versions? I think the current benchmark results are pretty out-of-date...

@csgillespie
Copy link
Owner

The main reason vroom can be faster is because character data is read from the file lazily; you only pay for the data you use. This lazy access is done automatically, so no changes to your R data-manipulation code are needed.

Source: https://www.tidyverse.org/blog/2019/05/vroom-1-0-0/

Cheers

@Robinlovelace
Copy link
Collaborator Author

Makes sense. We could add that caveat to the text - that's a good starting point, especially as some char string variables are not used. Re the implementation, that's amazing. Does it mean that an object created by vroom knows the file that generated it and will convert the text to character representation only if that column is used?

@Robinlovelace
Copy link
Collaborator Author

Worth documenting that and adding a link to the book I think, a very interested and fast implementation.

@engineerchange
Copy link
Contributor

I'm hoping to take a look at this a bit later in the week. I do agree to printing package versions though; I think it's a quick way to know if the benchmark is wildly out of date.

@Robinlovelace
Copy link
Collaborator Author

Great, thanks @engineerchange. Any additions on top of this branch very welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants