Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sqitch integration #386

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Sqitch integration #386

wants to merge 5 commits into from

Conversation

Expressionless-Ball-Thing
Copy link
Contributor

@Expressionless-Ball-Thing Expressionless-Ball-Thing commented Sep 24, 2023

  • Added an sqitch container to the code.
  • Ported all current Postgres scripts into the new sqitch folder.
  • placed a link to the sqitch documentation

… files into it, along with scripts to interact with sqitch, no idea if it works.
@Varun-Sethu
Copy link
Member

Why is the git diff so large? Did you change the line ending or smth?

@Expressionless-Ball-Thing
Copy link
Contributor Author

Expressionless-Ball-Thing commented Sep 24, 2023

Why is the git diff so large? Did you change the line ending or smth?

Well, I was working on this locally with Windows, one of the frontend folder's has a space in its pathname, which freaked Windows out. So I have to manually copy and post everything in that folder, which might explain why the git diff is so large.

Also, because of this, I can't even switch branch back to main.

Because Windows will go "uhh.... there's a space bar in one of the folder's path name, I don't like it because I don't know how to interpret that, so no, I am not gonna switch your branch."

@brianzhang2101
Copy link
Contributor

maybe let's wait for this to be merged
#385

@lauraw0
Copy link
Contributor

lauraw0 commented Sep 28, 2023

#385 has been merged

@Varun-Sethu
Copy link
Member

Now that that PR has been merged you should revert a lot of the unrelated changes

Copy link
Member

@Varun-Sethu Varun-Sethu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you link some documentation on how exactly to use this migration system? Or create some documentation outlining how its meant to be used

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need this anymore? now that we're using sqitch for migrations we dont need that python migration system

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants