Rename IoManager.make_non_blocking to be private #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barisione
commented
Aug 13, 2022
| @@ -2,6 +2,12 @@ | |||
|
|
|||
| ## dev | |||
|
|
|||
| **Breaking changes** | |||
|
|
|||
| - Removed `pygdbmi.IoManager.make_non_blocking` from the public API; it's unrelated and was not meant to be public | |||
There was a problem hiding this comment.
This is my interpretation but I'm not sure if it's correct (see the PR description).
cs01
approved these changes
Aug 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG.mdSummary of changes
make_non_blockingis currently public and has a docstring (so it appears in the docs) but I think it may have been exposed by mistake as it seems unrelated to the main goals of pygdbmi.Moreover, it's likely that fixing #54 will mean removing it.
Test plan
Tested by running