Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue # 54: IoManager._get_responses_windows mangles token when reading from stdout #55

Closed
wants to merge 10 commits into from

Conversation

leonardopsantos
Copy link

@leonardopsantos leonardopsantos commented May 19, 2021

SUPERSEDED BY #76

  • I have added an entry to CHANGELOG.md

Summary of changes

Fixes issue #54

Removed the make_non_blocking function. Refactored the _get_responses_windows method to use separate threads and queues to make reading non-blocking. solution based on this StackOverflow answer

Test plan

Executed unit tests:

$ python test_pygdbmi.py
....
----------------------------------------------------------------------
Ran 4 tests in 8.774s

OK

@cs01
Copy link
Owner

cs01 commented Jan 16, 2022

Hey, sorry for the ridiculously delayed reply, and thanks for taking the time to contribute.

Would you be interested in updating this to fix the merge conflict and make the CI tests pass? I will give you a quick review (within a few days) if you choose to.

@cs01
Copy link
Owner

cs01 commented Jan 16, 2022

I like that stack overflow answer. Getting rid of OS-specific stuff would be nice.

@barisione
Copy link
Collaborator

As the patch was not updated, I can take this and rebased it against master.

@barisione barisione self-assigned this Aug 7, 2022
@leonardopsantos
Copy link
Author

Sorry for the super late reply. I'd appreciate it if anyone could rebase this as I switched jobs and no longer have access to a Windows system.

barisione pushed a commit to barisione/pygdbmi that referenced this pull request Aug 13, 2022
Original patch by Leonardo Pereira Santos (see
cs01#55); updated by Marco Barisione.
@barisione
Copy link
Collaborator

I made a separate PR (#76) to update this (as I cannot push to somebody else's repository). Tests don't pass on Unix and I'm reluctant to modify the code as I cannot test it on Windows.

@barisione barisione closed this Aug 13, 2022
barisione pushed a commit to barisione/pygdbmi that referenced this pull request Aug 14, 2022
Original patch by Leonardo Pereira Santos (see
cs01#55); updated by Marco Barisione.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants