Add improper_instruction_introspection lint

crytic · Jun 21, 2024 · fa7f647 · fa7f647
1 parent 6d00637
commit fa7f647
Show file tree

Hide file tree

Showing 17 changed files with 3,856 additions and 10 deletions.
diff --git a/README.md b/README.md
@@ -8,15 +8,16 @@ The lints are inspired by the [Sealevel Attacks]. (See also @pencilflip's [Twitt
 
 The current lints are:
 
-| Library                                                          | Description                                                                                                                              | Anchor             | Non Anchor         |
-| ---------------------------------------------------------------- | ---------------------------------------------------------------------------------------------------------------------------------------- | ------------------ | ------------------ |
-| [`arbitrary_cpi`](lints/arbitrary_cpi)                           | lint for [5-arbitrary-cpi](https://github.com/coral-xyz/sealevel-attacks/tree/master/programs/5-arbitrary-cpi)                           | :heavy_check_mark: | :heavy_check_mark: |
-| [`bump_seed_canonicalization`](lints/bump_seed_canonicalization) | lint for [6-bump-seed-canonicalization](https://github.com/coral-xyz/sealevel-attacks/tree/master/programs/7-bump-seed-canonicalization) |                    | :heavy_check_mark: |
-| [`insecure_account_close`](lints/insecure_account_close)         | lint for [9-closing-accounts](https://github.com/coral-xyz/sealevel-attacks/tree/master/programs/9-closing-accounts)                     | :heavy_check_mark: | :heavy_check_mark: |
-| [`missing_owner_check`](lints/missing_owner_check)               | lint for [2-owner-checks](https://github.com/coral-xyz/sealevel-attacks/tree/master/programs/2-owner-checks)                             | :heavy_check_mark: | :heavy_check_mark: |
-| [`missing_signer_check`](lints/missing_signer_check)             | lint for [0-signer-authorization](https://github.com/coral-xyz/sealevel-attacks/tree/master/programs/0-signer-authorization)             | :heavy_check_mark: | :heavy_check_mark: |
-| [`sysvar_get`](lints/sysvar_get)                                 | Reports uses of `Sysvar::from_account_info` instead of `Sysvar::get`                                                                     | :heavy_check_mark: | :heavy_check_mark: |
-| [`type_cosplay`](lints/type_cosplay)                             | lint for [3-type-cosplay](https://github.com/coral-xyz/sealevel-attacks/tree/master/programs/3-type-cosplay)                             |                    | :heavy_check_mark: |
+| Library                                                                          | Description                                                                                                                              | Anchor             | Non Anchor         |
+| -------------------------------------------------------------------------------- | ---------------------------------------------------------------------------------------------------------------------------------------- | ------------------ | ------------------ |
+| [`arbitrary_cpi`](lints/arbitrary_cpi)                                           | lint for [5-arbitrary-cpi](https://github.com/coral-xyz/sealevel-attacks/tree/master/programs/5-arbitrary-cpi)                           | :heavy_check_mark: | :heavy_check_mark: |
+| [`bump_seed_canonicalization`](lints/bump_seed_canonicalization)                 | lint for [6-bump-seed-canonicalization](https://github.com/coral-xyz/sealevel-attacks/tree/master/programs/7-bump-seed-canonicalization) |                    | :heavy_check_mark: |
+| [`improper_instruction_introspection`](lints/improper_instruction_introspection) | Reports uses of absolute indexes for accessing instructions (`load_instruction_at_checked`)                                              | :heavy_check_mark: | :heavy_check_mark: |
+| [`insecure_account_close`](lints/insecure_account_close)                         | lint for [9-closing-accounts](https://github.com/coral-xyz/sealevel-attacks/tree/master/programs/9-closing-accounts)                     | :heavy_check_mark: | :heavy_check_mark: |
+| [`missing_owner_check`](lints/missing_owner_check)                               | lint for [2-owner-checks](https://github.com/coral-xyz/sealevel-attacks/tree/master/programs/2-owner-checks)                             | :heavy_check_mark: | :heavy_check_mark: |
+| [`missing_signer_check`](lints/missing_signer_check)                             | lint for [0-signer-authorization](https://github.com/coral-xyz/sealevel-attacks/tree/master/programs/0-signer-authorization)             | :heavy_check_mark: | :heavy_check_mark: |
+| [`sysvar_get`](lints/sysvar_get)                                                 | Reports uses of `Sysvar::from_account_info` instead of `Sysvar::get`                                                                     | :heavy_check_mark: | :heavy_check_mark: |
+| [`type_cosplay`](lints/type_cosplay)                                             | lint for [3-type-cosplay](https://github.com/coral-xyz/sealevel-attacks/tree/master/programs/3-type-cosplay)                             |                    | :heavy_check_mark: |
 
 ## Usage
 

diff --git a/crate/src/paths.rs b/crate/src/paths.rs
@@ -54,3 +54,8 @@ pub const SYSVAR_FEES: [&str; 3] = ["solana_program", "fees", "Fees"];
 pub const SYSVAR_LAST_RESTART_SLOT: [&str; 3] =
     ["solana_program", "last_restart_slot", "LastRestartSlot"];
 pub const SYSVAR_RENT: [&str; 3] = ["solana_program", "rent", "Rent"];
+pub const LOAD_INSTRUCTION_AT_CHECKED: [&str; 3] = [
+    "solana_program",
+    "instructions",
+    "load_instruction_at_checked",
+];
diff --git a/lints/improper_instruction_introspection/.cargo/config.toml b/lints/improper_instruction_introspection/.cargo/config.toml
@@ -0,0 +1,14 @@
+[build]
+target-dir = "../../target"
+
+[target.aarch64-apple-darwin]
+linker = "dylint-link"
+
+[target.x86_64-apple-darwin]
+linker = "dylint-link"
+
+[target.x86_64-unknown-linux-gnu]
+linker = "dylint-link"
+
+[target.x86_64-pc-windows-msvc]
+linker = "dylint-link"