fix: exclude interfaces in inheritance-graph edges#2979
Open
rajatbeladiya wants to merge 1 commit intocrytic:masterfrom
Open
fix: exclude interfaces in inheritance-graph edges#2979rajatbeladiya wants to merge 1 commit intocrytic:masterfrom
rajatbeladiya wants to merge 1 commit intocrytic:masterfrom
Conversation
|
|
Use the filtered immediate inheritance list when emitting edges so interfaces are excluded by default unless --include-interfaces is set. Adds regression test where interface appears before base contract.
rajatbeladiya
force-pushed
the
fix/inheritance-graph-ignore-interfaces-2150
branch
from
f1e1382 to
ec251d1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The inheritance-graph printer builds a filtered list of immediate inheritance (excluding mocks and, by default, interfaces). However, when the filtered list had length 1, it still emitted the edge using , which can be an interface depending on declaration order.
This PR uses the filtered list consistently, and adds a regression test where an interface is listed before a base contract.
Closes #2150.