feat: add detector for incorrect memory-safe-assembly annotations#2973
Closed
ep0chzer0 wants to merge 1 commit intocrytic:masterfrom
Closed
feat: add detector for incorrect memory-safe-assembly annotations#2973ep0chzer0 wants to merge 1 commit intocrytic:masterfrom
ep0chzer0 wants to merge 1 commit intocrytic:masterfrom
Conversation
The `@solidity memory-safe-assembly` annotation only works in NatSpec comments (`///` or `/** */`). Using it in regular comments (`//` or `/* */`) is silently ignored by the compiler. This detector flags: - Regular single-line comments with the annotation (// instead of ///) - Regular multi-line comments with the annotation (/* */ instead of /** */) - Common misspellings in NatSpec annotations Addresses crytic#2780
Contributor
Author
|
Closing as duplicate - this issue is already addressed by #2943. Apologies for the duplicate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@solidity memory-safe-assemblyannotation///or/** */). Using it in regular comments (//or/* */) is silently ignored by the compiler, so expected memory optimizations are never applied.//instead of///)/* */instead of/** */)memory-sage-assembly)Test plan