Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implicit conversion #2079

Draft
wants to merge 2 commits into
base: dev
Choose a base branch
from
Draft

Implicit conversion #2079

wants to merge 2 commits into from

Conversation

smonicas
Copy link
Contributor

@smonicas smonicas commented Aug 7, 2023

Add correct type for Literals and implicit conversion for assignment and binary operations, other operations where implicit conversion is possible are still todo.
Known issues:

  • Tautology detector doesn't work anymore
  • Literals with subdenomination e.g. 10 ether are still fixed to uint256
  • (uint a, uint b) = f() the implicit conversion doesn't work because TupleVariable doesn't have the type set

@0xalpharush 0xalpharush mentioned this pull request Jan 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@montyly montyly Awaiting requested review from montyly montyly will be requested when the pull request is marked ready for review montyly is a code owner

@0xalpharush 0xalpharush Awaiting requested review from 0xalpharush 0xalpharush will be requested when the pull request is marked ready for review 0xalpharush is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@smonicas