Fix incorrect confidence on assert state change detector

crytic · Dec 18, 2020 · e0fae81 · e0fae81
1 parent e44387a
commit e0fae81
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 573 deletions.
diff --git a/README.md b/README.md
@@ -113,7 +113,7 @@ Num | Detector | What it Detects | Impact | Confidence
 62 | `solc-version` | [Incorrect Solidity version](https://github.com/crytic/slither/wiki/Detector-Documentation#incorrect-versions-of-solidity) | Informational | High
 63 | `unimplemented-functions` | [Unimplemented functions](https://github.com/crytic/slither/wiki/Detector-Documentation#unimplemented-functions) | Informational | High
 64 | `unused-state` | [Unused state variables](https://github.com/crytic/slither/wiki/Detector-Documentation#unused-state-variables) | Informational | High
-65 | `assert-state-change` | [Assert state change](https://github.com/crytic/slither/wiki/Detector-Documentation#assert-state-change) | Informational | Informational
+65 | `assert-state-change` | [Assert state change](https://github.com/crytic/slither/wiki/Detector-Documentation#assert-state-change) | Informational | High
 66 | `costly-loop` | [Costly operations in a loop](https://github.com/crytic/slither/wiki/Detector-Documentation#costly-operations-inside-a-loop) | Informational | Medium
 67 | `reentrancy-unlimited-gas` | [Reentrancy vulnerabilities through send and transfer](https://github.com/crytic/slither/wiki/Detector-Documentation#reentrancy-vulnerabilities-4) | Informational | Medium
 68 | `similar-names` | [Variable names are too similar](https://github.com/crytic/slither/wiki/Detector-Documentation#variable-names-are-too-similar) | Informational | Medium

diff --git a/slither/detectors/statements/assert_state_change.py b/slither/detectors/statements/assert_state_change.py
@@ -45,7 +45,7 @@ class AssertStateChange(AbstractDetector):
     ARGUMENT = "assert-state-change"
     HELP = "Assert state change"
     IMPACT = DetectorClassification.INFORMATIONAL
-    CONFIDENCE = DetectorClassification.INFORMATIONAL
+    CONFIDENCE = DetectorClassification.HIGH
 
     WIKI = "https://github.com/crytic/slither/wiki/Detector-Documentation#assert-state-change"
     WIKI_TITLE = "Assert state shange"