Merge pull request #2476 from crytic/fixups

fix ordering and dead-code detector
crytic · Jun 5, 2024 · 798c1f6 · 798c1f6
2 parents 353d4da + 2e6508f
commit 798c1f6
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/slither/__main__.py b/slither/__main__.py
@@ -239,6 +239,7 @@ def choose_detectors(
             set(detectors_to_run), args.detectors_to_include, detectors
         )
 
+    detectors_to_run = sorted(detectors_to_run, key=lambda x: x.IMPACT)
     return detectors_to_run
 
 
@@ -255,7 +256,6 @@ def __include_detectors(
         else:
             raise ValueError(f"Error: {detector} is not a detector")
 
-    detectors_to_run = sorted(detectors_to_run, key=lambda x: x.IMPACT)
     return detectors_to_run
 
 

diff --git a/slither/detectors/functions/dead_code.py b/slither/detectors/functions/dead_code.py
@@ -71,9 +71,10 @@ def _detect(self) -> List[Output]:
                 continue
             if isinstance(function, FunctionContract) and (
                 function.contract_declarer.is_from_dependency()
+                or function.contract_declarer.is_library
             ):
                 continue
-            # Continue if the functon is not implemented because it means the contract is abstract
+            # Continue if the function is not implemented because it means the contract is abstract
             if not function.is_implemented:
                 continue
             info: DETECTOR_INFO = [function, " is never used and should be removed\n"]