Skip to content

Commit

Permalink
Merge pull request #719 from crytic/dev-contributing-guidelines
Browse files Browse the repository at this point in the history
Fixing typos in CONTRIBUTING doc
  • Loading branch information
montyly authored Dec 4, 2020
2 parents addd5b2 + 92c5f4d commit 37a44b3
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -44,14 +44,14 @@ For each new detector, at least one regression tests must be present.

- Create a test in `tests`
- Update `ALL_TEST` in `tests/test_detectors.py`
- Run `python ./test/test_detectors.py --generate`. This will generate the json artifacts in `tests/expected_json`. Add the generated files to git.
- Run `pytest ./test/test_detectors.py` and check that everything worked.
- Run `python ./tests/test_detectors.py --generate`. This will generate the json artifacts in `tests/expected_json`. Add the generated files to git.
- Run `pytest ./tests/test_detectors.py` and check that everything worked.

To see the tests coverage, run `pytest tests/test_detectors.py --cov=slither/detectors --cov-branch --cov-report html`

### Parser tests
- Create a test in `tests/ast-parsing`
- Run `python ./test/test_ast_parsing.py --generate`. This will generate the json artifacts in `tests/expected_json`. Add the generated files to git.
- Run `pytest ./test/test_ast_parsing.py` and check that everything worked.
- Run `python ./tests/test_ast_parsing.py --generate`. This will generate the json artifacts in `tests/expected_json`. Add the generated files to git.
- Run `pytest ./tests/test_ast_parsing.py` and check that everything worked.

To see the tests coverage, run `pytest tests/test_ast_parsing.py --cov=slither/solc_parsing --cov-branch --cov-report html`

0 comments on commit 37a44b3

Please sign in to comment.