Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some comments #559

Merged
merged 1 commit into from
Apr 14, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix some comments
Signed-off-by: pullmerge <[email protected]>
pullmerge committed Apr 14, 2024
commit 62354dd55387d242b74cfcc80038d87fe22c8fa8
6 changes: 3 additions & 3 deletions crytic_compile/platform/solc.py
Original file line number Diff line number Diff line change
@@ -468,7 +468,7 @@ def _run_solc(
solc_disable_warnings (bool): If True, disable solc warnings
solc_arguments (Optional[str]): Additional solc cli arguments
solc_remaps (Optional[Union[str, List[str]]], optional): Solc remaps. Can be a string where remap are separated with space, or list of str, or a list of. Defaults to None.
env (Optional[Dict]): Environement variable when solc is run. Defaults to None.
env (Optional[Dict]): Environment variable when solc is run. Defaults to None.
working_dir (Optional[Union[Path, str]]): Working directory when solc is run. Defaults to None.
force_legacy_json (bool): Force to use the legacy json format. Defaults to False.

@@ -607,7 +607,7 @@ def _run_solcs_path(
solc_disable_warnings (bool): If True, disable solc warnings
solc_arguments (str): Additional solc cli arguments
solc_remaps (Optional[Union[str, List[str]]], optional): Solc remaps. Can be a string where remap are separated with space, or list of str, or a list of. Defaults to None.
env (Optional[Dict]): Environement variable when solc is run. Defaults to None.
env (Optional[Dict]): Environment variable when solc is run. Defaults to None.
working_dir (Optional[Union[Path, str]], optional): Working directory when solc is run. Defaults to None.
force_legacy_json (bool): Force to use the legacy json format. Defaults to False.

@@ -697,7 +697,7 @@ def _run_solcs_env(
solc_disable_warnings (bool): If True, disable solc warnings
solc_arguments (str): Additional solc cli arguments
solc_remaps (Optional[Union[str, List[str]]], optional): Solc remaps. Can be a string where remap are separated with space, or list of str, or a list of. Defaults to None.
env (Optional[Dict], optional): Environement variable when solc is run. Defaults to None.
env (Optional[Dict], optional): Environment variable when solc is run. Defaults to None.
working_dir (Optional[Union[Path, str]], optional): Working directory when solc is run. Defaults to None.
solcs_env (Optional[List[str]]): List of solc env variable to try. Defaults to None.
force_legacy_json (bool): Force to use the legacy json format. Defaults to False.
2 changes: 1 addition & 1 deletion crytic_compile/platform/waffle.py
Original file line number Diff line number Diff line change
@@ -321,7 +321,7 @@ def _load_config(config_file: str) -> Dict:


def _get_version(compiler: str, cwd: str, config: Optional[Dict] = None) -> str:
"""Return the solidity verison used
"""Return the solidity version used

Args:
compiler (str): compiler used
2 changes: 1 addition & 1 deletion scripts/ci_test_truffle.sh
Original file line number Diff line number Diff line change
@@ -14,7 +14,7 @@ then
echo "Truffle test failed"
exit 255
fi
# TODO: for some reason truffle output is not deterministc
# TODO: for some reason truffle output is not deterministic
# The assigned id changes
#cd -
#