Skip to content

Commit

Permalink
Merge pull request #559 from pullmerge/master
Browse files Browse the repository at this point in the history
Fix some comments
0xalpharush authored Apr 14, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
2 parents 59b2b75 + 62354dd commit 93c106e
Showing 3 changed files with 5 additions and 5 deletions.
6 changes: 3 additions & 3 deletions crytic_compile/platform/solc.py
Original file line number Diff line number Diff line change
@@ -468,7 +468,7 @@ def _run_solc(
solc_disable_warnings (bool): If True, disable solc warnings
solc_arguments (Optional[str]): Additional solc cli arguments
solc_remaps (Optional[Union[str, List[str]]], optional): Solc remaps. Can be a string where remap are separated with space, or list of str, or a list of. Defaults to None.
env (Optional[Dict]): Environement variable when solc is run. Defaults to None.
env (Optional[Dict]): Environment variable when solc is run. Defaults to None.
working_dir (Optional[Union[Path, str]]): Working directory when solc is run. Defaults to None.
force_legacy_json (bool): Force to use the legacy json format. Defaults to False.
@@ -607,7 +607,7 @@ def _run_solcs_path(
solc_disable_warnings (bool): If True, disable solc warnings
solc_arguments (str): Additional solc cli arguments
solc_remaps (Optional[Union[str, List[str]]], optional): Solc remaps. Can be a string where remap are separated with space, or list of str, or a list of. Defaults to None.
env (Optional[Dict]): Environement variable when solc is run. Defaults to None.
env (Optional[Dict]): Environment variable when solc is run. Defaults to None.
working_dir (Optional[Union[Path, str]], optional): Working directory when solc is run. Defaults to None.
force_legacy_json (bool): Force to use the legacy json format. Defaults to False.
@@ -697,7 +697,7 @@ def _run_solcs_env(
solc_disable_warnings (bool): If True, disable solc warnings
solc_arguments (str): Additional solc cli arguments
solc_remaps (Optional[Union[str, List[str]]], optional): Solc remaps. Can be a string where remap are separated with space, or list of str, or a list of. Defaults to None.
env (Optional[Dict], optional): Environement variable when solc is run. Defaults to None.
env (Optional[Dict], optional): Environment variable when solc is run. Defaults to None.
working_dir (Optional[Union[Path, str]], optional): Working directory when solc is run. Defaults to None.
solcs_env (Optional[List[str]]): List of solc env variable to try. Defaults to None.
force_legacy_json (bool): Force to use the legacy json format. Defaults to False.
2 changes: 1 addition & 1 deletion crytic_compile/platform/waffle.py
Original file line number Diff line number Diff line change
@@ -321,7 +321,7 @@ def _load_config(config_file: str) -> Dict:


def _get_version(compiler: str, cwd: str, config: Optional[Dict] = None) -> str:
"""Return the solidity verison used
"""Return the solidity version used
Args:
compiler (str): compiler used
2 changes: 1 addition & 1 deletion scripts/ci_test_truffle.sh
Original file line number Diff line number Diff line change
@@ -14,7 +14,7 @@ then
echo "Truffle test failed"
exit 255
fi
# TODO: for some reason truffle output is not deterministc
# TODO: for some reason truffle output is not deterministic
# The assigned id changes
#cd -
#

0 comments on commit 93c106e

Please sign in to comment.