Refactoring Resolver #659
Draft
Refactoring Resolver #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…version_control.cr Returning crystal.cr, path.cr and resolver.cr to previous condition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #574 I tried refactoring the resolver code. All existing tests still pass.
An additional VersionControlResolver class that Git/Hg/Fossil inherit from has been introduced.
As part of the refactor I also fixed a bug in the version handling of fossil (standardizing on the included
versionscode rather relying on a somewhat broken compares of the unnecessary major/minor/patch variables (which were removed as part of the refactor).Creating as a draft for now, still a few more tweaks to go.