Add support for Codeberg as a git resolver (#656)

Co-authored-by: Devonte <[email protected]> Co-authored-by: Johannes Müller <[email protected]>
crystal-lang · Nov 18, 2024 · 7e312bb · 7e312bb
1 parent 20aaeaf
commit 7e312bb
Show file tree

Hide file tree

Showing 5 changed files with 43 additions and 3 deletions.
diff --git a/docs/shard.yml.adoc b/docs/shard.yml.adoc
@@ -273,7 +273,7 @@ A path to the source file to compile (string).
 == DEPENDENCY ATTRIBUTES
 
 Each dependency needs at least one attribute that defines the resolver for this
-dependency. Those can be _path_, _git_, _github_, _gitlab_, _bitbucket_.
+dependency. Those can be _path_, _git_, _github_, _gitlab_, _bitbucket_, _codeberg_.
 
 *path*::
 A local path (string).
@@ -320,6 +320,13 @@ Extends the _git_ resolver, and acts exactly like it.
 +
 *Example:* _bitbucket: tom/library_
 
+*codeberg*::
+Codeberg repository URL as _user/repo_ (string).
++
+Extends the _git_ resolver, and acts exactly like it.
++
+*Example:* _codeberg: tom/library_
+
 *hg*::
 
 A Mercurial repository URL (string).

diff --git a/docs/shard.yml.schema.json b/docs/shard.yml.schema.json
@@ -57,6 +57,11 @@
             "title": "Bitbucket URL",
             "description": "Bitbucket repository URL as user/repo"
           },
+          "codeberg": {
+            "type": "string",
+            "title": "Codeberg URL",
+            "description": "Codeberg repository URL as user/repo"
+          },
           "git": {
             "type": "string",
             "title": "git URL",
@@ -130,6 +135,11 @@
             "title": "Bitbucket URL",
             "description": "Bitbucket repository URL as user/repo"
           },
+          "codeberg": {
+            "type": "string",
+            "title": "Codeberg URL",
+            "description": "Codeberg repository URL as user/repo"
+          },
           "git": {
             "type": "string",
             "title": "git URL",

diff --git a/man/shard.yml.5 b/man/shard.yml.5
diff --git a/spec/unit/git_resolver_spec.cr b/spec/unit/git_resolver_spec.cr
@@ -39,12 +39,14 @@ module Shards
       GitResolver.normalize_key_source("gitlab", "repo/path").should eq({"git", "https://gitlab.com/repo/path.git"})
       GitResolver.normalize_key_source("gitlab", "rEpo/pAth").should eq({"git", "https://gitlab.com/repo/path.git"})
       GitResolver.normalize_key_source("gitlab", "REPO/PATH").should eq({"git", "https://gitlab.com/repo/path.git"})
+      GitResolver.normalize_key_source("codeberg", "REPO/PATH").should eq({"git", "https://codeberg.org/repo/path.git"})
 
       # normalise full git paths
       GitResolver.normalize_key_source("git", "HTTPS://User:[email protected]/Repo/Path.git?Shallow=true")[1].should eq "https://User:[email protected]/repo/path.git?Shallow=true"
       GitResolver.normalize_key_source("git", "HTTPS://User:[email protected]/Repo/Path.Git?Shallow=true")[1].should eq "https://User:[email protected]/repo/path.git?Shallow=true"
       GitResolver.normalize_key_source("git", "HTTPS://User:[email protected]/Repo/Path?Shallow=true")[1].should eq "https://User:[email protected]/repo/path.git?Shallow=true"
       GitResolver.normalize_key_source("git", "HTTPS://User:[email protected]/Repo/Path?Shallow=true")[1].should eq "https://User:[email protected]/repo/path.git?Shallow=true"
+      GitResolver.normalize_key_source("git", "HTTPS://User:[email protected]/Repo/Path.Git?Shallow=true")[1].should eq "https://User:[email protected]/repo/path.git?Shallow=true"
 
       # don't normalise other domains
       GitResolver.normalize_key_source("git", "HTTPs://mygitserver.com/Repo.git").should eq({"git", "HTTPs://mygitserver.com/Repo.git"})

diff --git a/src/resolvers/git.cr b/src/resolvers/git.cr
@@ -100,7 +100,16 @@ module Shards
       "git"
     end
 
-    private KNOWN_PROVIDERS = {"www.github.com", "github.com", "www.bitbucket.com", "bitbucket.com", "www.gitlab.com", "gitlab.com"}
+    private KNOWN_PROVIDERS = {
+      "www.github.com",
+      "github.com",
+      "www.bitbucket.com",
+      "bitbucket.com",
+      "www.gitlab.com",
+      "gitlab.com",
+      "www.codeberg.org",
+      "codeberg.org",
+    }
 
     def self.normalize_key_source(key : String, source : String) : {String, String}
       case key
@@ -120,6 +129,8 @@ module Shards
         end
       when "github", "bitbucket", "gitlab"
         {"git", "https://#{key}.com/#{source.downcase}.git"}
+      when "codeberg"
+        {"git", "https://#{key}.org/#{source.downcase}.git"}
       else
         raise "Unknown resolver #{key}"
       end
@@ -458,5 +469,6 @@ module Shards
     register_resolver "github", GitResolver
     register_resolver "gitlab", GitResolver
     register_resolver "bitbucket", GitResolver
+    register_resolver "codeberg", GitResolver
   end
 end