Skip to content

CI: Refactor matrix configuration in Linux workflow #16331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 7, 2025
Merged

CI: Refactor matrix configuration in Linux workflow #16331

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e370b2b
Add `CRYSTAL_BOOTSTRAP_VERSION` env var
straight-shoota Nov 5, 2025
63a21a5
Refactor matrix parameters into `env`
straight-shoota Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 18 additions & 9 deletions .github/workflows/forward-compatibility.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,27 +29,35 @@ jobs:
env:
ARCH: x86_64
ARCH_CMD: linux64
DOCKER_TEST_PREFIX: crystallang/crystal:${{ matrix.crystal_bootstrap_version }}
CRYSTAL_BOOTSTRAP_VERSION: ${{ matrix.crystal_bootstrap_version }}
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
crystal_bootstrap_version: [1.7.3, 1.8.2, 1.9.2, 1.10.1, 1.11.2, 1.12.2, 1.13.3, 1.14.1, 1.15.1, 1.16.3, 1.17.1]
flags: [""]
env: [{}]
include:
# libffi is only available starting from the 1.2.2 build images
# pcre2 is only available starting from the 1.7.0 build images
- crystal_bootstrap_version: 1.1.1
flags: "FLAGS=-Dwithout_ffi USE_PCRE1=true"
env:
FLAGS: -Dwithout_ffi
USE_PCRE1: true
- crystal_bootstrap_version: 1.2.2
flags: "USE_PCRE1=true"
env:
USE_PCRE1: true
- crystal_bootstrap_version: 1.3.2
flags: "USE_PCRE1=true"
env:
USE_PCRE1: true
- crystal_bootstrap_version: 1.4.1
flags: "USE_PCRE1=true"
env:
USE_PCRE1: true
- crystal_bootstrap_version: 1.5.1
flags: "USE_PCRE1=true"
env:
USE_PCRE1: true
- crystal_bootstrap_version: 1.6.2
flags: "USE_PCRE1=true"
env:
USE_PCRE1: true
steps:
- name: Download Crystal source
uses: actions/checkout@v5
Expand All @@ -63,4 +71,5 @@ jobs:
run: bin/ci prepare_build

- name: Test
run: ${{ matrix.flags }} bin/ci build
run: bin/ci build
env: ${{ matrix.env }}
16 changes: 9 additions & 7 deletions .github/workflows/linux.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,17 +21,18 @@ jobs:
env:
ARCH: x86_64
ARCH_CMD: linux64
DOCKER_TEST_PREFIX: crystallang/crystal:${{ matrix.crystal_bootstrap_version }}
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
flags: [""]
env: [{}]
include:
# libffi is only available starting from the 1.2.2 build images
- crystal_bootstrap_version: 1.0.0
flags: "FLAGS=-Dwithout_ffi USE_PCRE1=true"
- crystal_bootstrap_version: 1.18.2 # LATEST RELEASE
- env:
CRYSTAL_BOOTSTRAP_VERSION: 1.0.0
# libffi is only available starting from the 1.2.2 build images
FLAGS: "-Dwithout_ffi"
# pcre2 is only available starting from the 1.7.0 build images
USE_PCRE1: true
steps:
- name: Download Crystal source
uses: actions/checkout@v5
Expand All @@ -45,7 +46,8 @@ jobs:
run: bin/ci prepare_build

- name: Test
run: ${{ matrix.flags }} bin/ci build
run: bin/ci build
env: ${{ matrix.env }}

x86_64-musl-test:
env:
Expand Down
2 changes: 1 addition & 1 deletion bin/ci
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ with_build_env() {

on_linux verify_linux_environment

export DOCKER_TEST_PREFIX="${DOCKER_TEST_PREFIX:=crystallang/crystal:1.18.2}"
export DOCKER_TEST_PREFIX="${DOCKER_TEST_PREFIX:="crystallang/crystal:${CRYSTAL_BOOTSTRAP_VERSION:-1.18.2}"}"

case $ARCH in
x86_64)
Expand Down