-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Add thread safety to default random #16174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ysbaddaden
wants to merge
15
commits into
crystal-lang:master
Choose a base branch
from
ysbaddaden:feature/thread-safe-default-random
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Add thread safety to default random #16174
ysbaddaden
wants to merge
15
commits into
crystal-lang:master
from
ysbaddaden:feature/thread-safe-default-random
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a simple abstraction over the `ThreadLocal` annotation (for quick access) that also injects a reference into `Thread.current` to keep the value visible to the GC (that can't scan `ThreadLocal` values). There is no support for destructors. When needed just use a class with a finalizer: when the Thread is collected the thread local value will also be collected, which will run the finalizer.
ReferenceStorage(T) needs a concrete type (not Random) and PCG32.new(self) requires the type to be a PCG32 instance (not any Random).
The goal is to avoid advertising a global random instance since even as a thread local it ain't always safe to use. We shall instead treat it as an internal implementation detail.
Refactors the `Crystal::System::Process.fork` methods on UNIX to only compile the call to `Random::DEFAULT` when using `Process.fork` not when calling `Process.new` or `Process.run`. The patch no longer hardcodes both `will_exec` paths, only the used ones will be compiled.
Sija
reviewed
Oct 2, 2025
We should probably extract the refactor of |
Or move to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #16157 and its comments for more details.
Random.default
thread local:Random::DEFAULT
Enumerable#sample(n)
(split thread local)Crystal::System::File.mktemp
(resolve thread local on each attempt)Random.default
to internalize its usage:Random.next_int
andRandom.next_bool
methods that can be called directly;Random::Secure.random_bytes
;Random
now default torandom = nil
Random::DEFAULT
Random::DEFAULT
warning onProcess.new
on UNIXTo be defined: we might want to keep
Random.default
undocumented 🤔Closes #16157.
Depends on #16173.